18xx-maker-git

LOW
maintainer zxp19821005 0 votes scanned 2026-10-07 06:05:09.924014
View on AUR
Why flagged

The package installs a version-pinned pnpm from npm via a variable derived from the project's own package.json, which is a normal build practice and not inherently dangerous.

Triggered rules

Low AI review of an ambiguous pattern llm_review

The static rules found a suspicious pattern they could not resolve, so an AI model (qwen/qwen3-235b-a22b-2507) reviewed it and judged it LOW (confidence 95%): The package installs a version-pinned pnpm from npm via a variable derived from the project's own package.json, which is a normal build practice and not inherently dangerous.

  • PKGBUILD:92 npm install -g "pnpm@${_pnpmver}" --prefix "${HOME}/.pnpm" \

PKGBUILD

1 offending line(s) highlighted
1# Maintainer: zxp19821005 <zxp19821005 at 163 dot com>
2pkgname=18xx-maker-git
3_pkgname='18xx Maker'
4pkgver=1.0.0.beta.131.r43.g0ec06e5
5_electronversion=44
6_nodeversion=24
7pkgrel=1
8pkgdesc="🚂 Prototyping tool for 18xx games 💸."
9arch=('any')
10url="https://18xx-maker.com"
11_ghurl="https://github.com/18xx-maker/18xx-maker"
12license=('MIT')
13conflicts=("${pkgname%-git}")
14provides=("${pkgname%-git}=${pkgver%.r*}")
15depends=(
16 "electron${_electronversion}"
17)
18makedepends=(
19 'gendesk'
20 'nvm'
21 'git'
22 'pnpm'
23 'npm'
24 'jq'
25)
26source=(
27 "${pkgname%-git}.git::git+${_ghurl}"
28 "${pkgname%-git}.sh"
29)
30sha256sums=('SKIP'
31 'bd5358d8f323d3c2c2f0733364ee4ea55f551dd86ba0be2a76846210b60897fc')
32_get_project_dir() {
33 local d
34 while IFS= read -r d; do
35 find "$d" -name "package.json" ! -path "*/node_modules/*" 2>/dev/null | grep -q . && { echo "$d"; return; }
36 done < <(find "${srcdir}" -maxdepth 1 -mindepth 1 -type d ! -name '.*')
37}
38pkgver() {
39 cd "$(_get_project_dir)"
40 set -o pipefail
41 git describe --long --tags --abbrev=7 | sed 's/\([^-]*-g\)/r\1/;s/-/./g;s/v//g' ||
42 printf "r%s.%s" "$(git rev-list --count HEAD)" "$(git rev-parse --short=7 HEAD)"
43}
44_ensure_local_nvm() {
45 local NVM_DIR="${srcdir}/.nvm"
46 source /usr/share/nvm/init-nvm.sh || [[ $? != 1 ]]
47 nvm install "${_nodeversion}"
48 nvm use "${_nodeversion}"
49}
50_get_app_dir() {
51 find "${srcdir}" -type f -name "resources.pak" -print 2>/dev/null | while read f; do [ -d "${f%/*}/resources" ] && echo "${f%/*}" && break; done
52}
53_get_electron_version() {
54 _elec_ver=$(find "$(_get_project_dir)" -name "package.json" ! -path "*/node_modules/*" -print \
55 | xargs -I{} jq -r '(.devDependencies.electron // .dependencies.electron) // empty' {} 2>/dev/null \
56 | grep -v '^$' | sed 's/^[^0-9]*//' | head -1)
57 [[ -z "${_elec_ver}" ]] && return 1
58 echo -e "The electron version is: \033[1;31m${_elec_ver%%.*}\033[0m"
59}
60_set_build_env() {
61 export ELECTRON_DIST="/usr/lib/electron${_electronversion}"
62 export ELECTRON_OVERRIDE_DIST_PATH="${ELECTRON_DIST}"
63 export ELECTRON_SKIP_BINARY_DOWNLOAD=1
64 export ELECTRON_BUILDER_OFFLINE=true
65 export SYSTEM_ELECTRON_VERSION="$(electron${_electronversion} -v | sed 's/^v//')"
66 export HOME="${srcdir}/.home"
67 export XDG_CACHE_HOME="${HOME}/.cache"
68 export XDG_CONFIG_HOME="${HOME}/.config"
69 export XDG_DATA_HOME="${HOME}/.local/share"
70 export XDG_STATE_HOME="${HOME}/.local/state"
71 export PNPM_HOME="${HOME}/.pnpm/bin"
72 export pnpm_config_cache_dir="${HOME}/.pnpm_cache"
73 export pnpm_config_store_dir="${HOME}/.pnpm_store"
74 export pnpm_config_global_dir="${HOME}/.pnpm/global"
75 export pnpm_config_state_dir="${HOME}/.pnpm/state"
76 export pnpm_config_node_linker=hoisted
77 export pnpm_config_minimum_release_age=0
78 export pnpm_config_update_notifier=false
79 export COREPACK_NPM_REGISTRY="${COREPACK_NPM_REGISTRY:-${NPM_CONFIG_REGISTRY:-https://registry.npmjs.org}}"
80 export COREPACK_HOME="${HOME}/.corepack"
81 mkdir -p "${HOME}" "${PNPM_HOME}" "${pnpm_config_cache_dir}" "${pnpm_config_store_dir}" "${pnpm_config_global_dir}" "${pnpm_config_state_dir}" "${COREPACK_HOME}"
82 export PATH="${PNPM_HOME}:${PATH}"
83 local _pnpmver=""
84 local _pkgjson="$(_get_project_dir)/package.json"
85 if [ -f "${_pkgjson}" ]; then
86 _pnpmver="$(grep -o '"packageManager"[^,]*' "${_pkgjson}" 2>/dev/null | grep -oE 'pnpm@[^"+]+' | head -n1 | sed 's/^pnpm@//')"
87 if [ -z "${_pnpmver}" ]; then
88 _pnpmver="$(grep -oE '"pnpm"[[:space:]]*:[[:space:]]*"[^"]+"' "${_pkgjson}" 2>/dev/null | grep -oE '[0-9][0-9.]*' | head -n1)"
89 fi
90 fi
91 if [ -n "${_pnpmver}" ]; then
92 npm install -g "pnpm@${_pnpmver}" --prefix "${HOME}/.pnpm" \
93 --registry "${COREPACK_NPM_REGISTRY}"
94 fi
95}
96prepare() {
97 cd "$(_get_project_dir)"
98 _get_electron_version
99 sed -i -e "
100 s/@electronversion@/${_electronversion}/g
101 s/@appname@/${pkgname%-git}/g
102 s/@runname@/app.asar/g
103 s/@cfgdirname@/${pkgname%-git}/g
104 s/@options@/env ELECTRON_OZONE_PLATFORM_HINT=auto/g
105 " "${srcdir}/${pkgname%-git}.sh"
106 gendesk -q -f -n \
107 --pkgname="${pkgname%-git}" \
108 --pkgdesc="${pkgdesc}" \
109 --categories="Development;Game" \
110 --name="${_pkgname}" \
111 --exec="${pkgname%-git} %U"
112 _ensure_local_nvm
113 _set_build_env
114 jq --arg ver "${SYSTEM_ELECTRON_VERSION}" '.devDependencies.electron = $ver' package.json > package.json.tmp && mv package.json.tmp package.json
115 rm -rf pnpm-lock.yaml
116 export NODE_ENV=development
117 pnpm install
118}
119build() {
120 cd "$(_get_project_dir)"
121 _ensure_local_nvm
122 _set_build_env
123 export NODE_ENV=production
124 pnpm run build:app
125 pnpm -c exec "electron-builder --linux dir -c.electronDist=${ELECTRON_DIST}"
126}
127package() {
128 install -Dm755 "${srcdir}/${pkgname%-git}.sh" "${pkgdir}/usr/bin/${pkgname%-git}"
129 install -Dm755 -d "${pkgdir}/usr/lib/${pkgname%-git}"
130 local _app_dir="$(_get_app_dir)"
131 cp -a "${_app_dir}/resources/." "${pkgdir}/usr/lib/${pkgname%-git}/"
132 rm -rf "${pkgdir}/usr/lib/${pkgname%-git}/default_app.asar"
133 local _src="$(_get_project_dir)"
134 install -Dm644 "${_src}/dist/app/linux-"*/resources/app.asar -t "${pkgdir}/usr/lib/${pkgname%-git}"
135 install -Dm644 "${_src}/${pkgname%-git}.desktop" -t "${pkgdir}/usr/share/applications"
136 install -Dm644 "${_src}/electron/assets/${pkgname%-git}.png" -t "${pkgdir}/usr/share/pixmaps"
137 install -Dm644 "${_src}/LICENSE" -t "${pkgdir}/usr/share/licenses/${pkgname}"
138}

Changes since previous scan

--- PKGBUILD @ 2026-06-18 16:11
+++ PKGBUILD @ 2026-10-07 06:05
@@ -1,11 +1,11 @@
# Maintainer: zxp19821005 <zxp19821005 at 163 dot com>
pkgname=18xx-maker-git
_pkgname='18xx Maker'
-pkgver=1.0.0.beta.118.r0.gc044c59
-_electronversion=33
-_nodeversion=22
+pkgver=1.0.0.beta.131.r43.g0ec06e5
+_electronversion=44
+_nodeversion=24
pkgrel=1
-pkgdesc="🚂 Prototyping tool for 18xx games 💸.(Use system-wide electron)"
+pkgdesc="🚂 Prototyping tool for 18xx games 💸."
arch=('any')
url="https://18xx-maker.com"
_ghurl="https://github.com/18xx-maker/18xx-maker"
@@ -19,7 +19,6 @@
'gendesk'
'nvm'
'git'
- 'curl'
'pnpm'
'npm'
'jq'
@@ -29,9 +28,15 @@
"${pkgname%-git}.sh"
)
sha256sums=('SKIP'
- '31ad33b633744f5361abd964be306cea53ae1050e760c787115f7eca60045ae6')
+ 'bd5358d8f323d3c2c2f0733364ee4ea55f551dd86ba0be2a76846210b60897fc')
+_get_project_dir() {
+ local d
+ while IFS= read -r d; do
+ find "$d" -name "package.json" ! -path "*/node_modules/*" 2>/dev/null | grep -q . && { echo "$d"; return; }
+ done < <(find "${srcdir}" -maxdepth 1 -mindepth 1 -type d ! -name '.*')
+}
pkgver() {
- cd "${srcdir}/${pkgname%-git}.git"
+ cd "$(_get_project_dir)"
set -o pipefail
git describe --long --tags --abbrev=7 | sed 's/\([^-]*-g\)/r\1/;s/-/./g;s/v//g' ||
printf "r%s.%s" "$(git rev-list --count HEAD)" "$(git rev-parse --short=7 HEAD)"
@@ -42,13 +47,54 @@
nvm install "${_nodeversion}"
nvm use "${_nodeversion}"
}
+_get_app_dir() {
+ find "${srcdir}" -type f -name "resources.pak" -print 2>/dev/null | while read f; do [ -d "${f%/*}/resources" ] && echo "${f%/*}" && break; done
+}
_get_electron_version() {
- _elec_ver=$(jq -r '.devDependencies["electron"] // .dependencies["electron"]' "${srcdir}/${pkgname%-git}.git/package.json" | tr -d '^')
- _main_ver=$(echo "${_elec_ver}" | cut -d. -f1)
- echo -e "The electron version is: \033[1;31m${_main_ver}\033[0m"
+ _elec_ver=$(find "$(_get_project_dir)" -name "package.json" ! -path "*/node_modules/*" -print \
+ | xargs -I{} jq -r '(.devDependencies.electron // .dependencies.electron) // empty' {} 2>/dev/null \
+ | grep -v '^$' | sed 's/^[^0-9]*//' | head -1)
+ [[ -z "${_elec_ver}" ]] && return 1
+ echo -e "The electron version is: \033[1;31m${_elec_ver%%.*}\033[0m"
+}
+_set_build_env() {
+ export ELECTRON_DIST="/usr/lib/electron${_electronversion}"
+ export ELECTRON_OVERRIDE_DIST_PATH="${ELECTRON_DIST}"
+ export ELECTRON_SKIP_BINARY_DOWNLOAD=1
+ export ELECTRON_BUILDER_OFFLINE=true
+ export SYSTEM_ELECTRON_VERSION="$(electron${_electronversion} -v | sed 's/^v//')"
+ export HOME="${srcdir}/.home"
+ export XDG_CACHE_HOME="${HOME}/.cache"
+ export XDG_CONFIG_HOME="${HOME}/.config"
+ export XDG_DATA_HOME="${HOME}/.local/share"
+ export XDG_STATE_HOME="${HOME}/.local/state"
+ export PNPM_HOME="${HOME}/.pnpm/bin"
+ export pnpm_config_cache_dir="${HOME}/.pnpm_cache"
+ export pnpm_config_store_dir="${HOME}/.pnpm_store"
+ export pnpm_config_global_dir="${HOME}/.pnpm/global"
+ export pnpm_config_state_dir="${HOME}/.pnpm/state"
+ export pnpm_config_node_linker=hoisted
+ export pnpm_config_minimum_release_age=0
+ export pnpm_config_update_notifier=false
+ export COREPACK_NPM_REGISTRY="${COREPACK_NPM_REGISTRY:-${NPM_CONFIG_REGISTRY:-https://registry.npmjs.org}}"
+ export COREPACK_HOME="${HOME}/.corepack"
+ mkdir -p "${HOME}" "${PNPM_HOME}" "${pnpm_config_cache_dir}" "${pnpm_config_store_dir}" "${pnpm_config_global_dir}" "${pnpm_config_state_dir}" "${COREPACK_HOME}"
+ export PATH="${PNPM_HOME}:${PATH}"
+ local _pnpmver=""
+ local _pkgjson="$(_get_project_dir)/package.json"
+ if [ -f "${_pkgjson}" ]; then
+ _pnpmver="$(grep -o '"packageManager"[^,]*' "${_pkgjson}" 2>/dev/null | grep -oE 'pnpm@[^"+]+' | head -n1 | sed 's/^pnpm@//')"
+ if [ -z "${_pnpmver}" ]; then
+ _pnpmver="$(grep -oE '"pnpm"[[:space:]]*:[[:space:]]*"[^"]+"' "${_pkgjson}" 2>/dev/null | grep -oE '[0-9][0-9.]*' | head -n1)"
+ fi
+ fi
+ if [ -n "${_pnpmver}" ]; then
+ npm install -g "pnpm@${_pnpmver}" --prefix "${HOME}/.pnpm" \
+ --registry "${COREPACK_NPM_REGISTRY}"
+ fi
}
prepare() {
- cd "${srcdir}/${pkgname%-git}.git"
+ cd "$(_get_project_dir)"
_get_electron_version
sed -i -e "
s/@electronversion@/${_electronversion}/g
@@ -63,53 +109,30 @@
--categories="Development;Game" \
--name="${_pkgname}" \
--exec="${pkgname%-git} %U"
- export ELECTRON_SKIP_BINARY_DOWNLOAD=1
- export SYSTEM_ELECTRON_VERSION="$(electron${_electronversion} -v | sed 's/v//g')"
- HOME="${srcdir}/.electron-gyp"
- {
- echo -e '\n'
- #echo 'build_from_source=true'
- echo 'link-workspace-packages=true'
- echo 'fetch-retry-maxtimeout=10000'
- echo "cache-dir="${srcdir}"/.pnpm_cache"
- echo "store-dir="${srcdir}"/.pnpm_store"
- echo "shamefully-hoist=true"
- echo "virtual-store-dir-max-length=80"
- echo "node-linker=hoisted"
- echo "network-concurrency=10"
- } >> .npmrc
- if [[ "$(curl -s ipinfo.io/country)" == *"CN"* ]]; then
- {
- echo 'registry=https://registry.npmmirror.com'
- echo 'electron_mirror=https://cdn.npmmirror.com/binaries/electron/'
- echo 'electron_builder_binaries_mirror=https://npmmirror.com/mirrors/electron-builder-binaries/'
- } >> .npmrc
- fi
_ensure_local_nvm
- sed -i "s/\"electron\": \"[^\"]*\"/\"electron\": \"${SYSTEM_ELECTRON_VERSION}\"/g" package.json
- NODE_ENV=development pnpm install
+ _set_build_env
+ jq --arg ver "${SYSTEM_ELECTRON_VERSION}" '.devDependencies.electron = $ver' package.json > package.json.tmp && mv package.json.tmp package.json
+ rm -rf pnpm-lock.yaml
+ export NODE_ENV=development
+ pnpm install
}
build() {
- cd "${srcdir}/${pkgname%-git}.git"
+ cd "$(_get_project_dir)"
_ensure_local_nvm
- local electronDist="/usr/lib/electron${_electronversion}"
- NODE_ENV=production pnpm run build:app
- NODE_ENV=production pnpm -c exec "electron-builder --linux dir -c.electronDist=${electronDist}"
+ _set_build_env
+ export NODE_ENV=production
+ pnpm run build:app
+ pnpm -c exec "electron-builder --linux dir -c.electronDist=${ELECTRON_DIST}"
}
package() {
install -Dm755 "${srcdir}/${pkgname%-git}.sh" "${pkgdir}/usr/bin/${pkgname%-git}"
install -Dm755 -d "${pkgdir}/usr/lib/${pkgname%-git}"
- find "${srcdir}/${pkgname%-git}.git/dist/app/linux-"*"/resources" -maxdepth 1 -type f -exec install -Dm644 -t "${pkgdir}/usr/lib/${pkgname%-git}" {} +
- if find "${srcdir}/${pkgname%-git}.git/dist/app/linux-"*"/resources" -mindepth 1 -maxdepth 1 -type d | read; then
- for _subdir in "${srcdir}/${pkgname%-git}.git/dist/app/linux-"*"/resources/"*; do
- if [ -d "${_subdir}" ]; then
- cp -Pr --no-preserve=ownership "${_subdir}" "${pkgdir}/usr/lib/${pkgname%-git}"
- fi
- done
- fi
- install -Dm644 "${srcdir}/${pkgname%-git}.git/dist/app/linux-"*/resources/app.asar -t "${pkgdir}/usr/lib/${pkgname%-git}"
- install -Dm644 "${srcdir}/${pkgname%-git}.git/${pkgname%-git}.desktop" -t "${pkgdir}/usr/share/applications"
- install -Dm644 "${srcdir}/${pkgname%-git}.git/electron/assets/${pkgname%-git}.png" -t "${pkgdir}/usr/share/pixmaps"
- install -Dm644 "${srcdir}/${pkgname%-git}.git/LICENSE" -t "${pkgdir}/usr/share/licenses/${pkgname}"
+ local _app_dir="$(_get_app_dir)"
+ cp -a "${_app_dir}/resources/." "${pkgdir}/usr/lib/${pkgname%-git}/"
+ rm -rf "${pkgdir}/usr/lib/${pkgname%-git}/default_app.asar"
+ local _src="$(_get_project_dir)"
+ install -Dm644 "${_src}/dist/app/linux-"*/resources/app.asar -t "${pkgdir}/usr/lib/${pkgname%-git}"
+ install -Dm644 "${_src}/${pkgname%-git}.desktop" -t "${pkgdir}/usr/share/applications"
+ install -Dm644 "${_src}/electron/assets/${pkgname%-git}.png" -t "${pkgdir}/usr/share/pixmaps"
+ install -Dm644 "${_src}/LICENSE" -t "${pkgdir}/usr/share/licenses/${pkgname}"
}
-

Scan history

Scanned at (UTC)SeverityRules
2026-10-07 06:05:09 Low 1
2026-06-18 16:11:54 Clean 0

Report a package

Reports go to the AURWatch maintainer (one person) and are read by hand. No login required.

0 / 4000
Your suggestion