bettersoundcloud

maintainer zxp19821005 · 0 votes · scanned 2026-08-03 00:08:14.047287

LOW

Why flagged The npm install runs within the project's own source tree for building, which is normal AUR practice; the external package addition is declared in the PKGBUILD and part of the build process, not an undeclared dependency injection.

Triggered rules

LOW AI review downgraded a static finding llm_review

The static rules flagged this MEDIUM, but an AI model (qwen/qwen3-235b-a22b-07-25) reviewed the full PKGBUILD and judged it LOW (confidence 90%): The npm install runs within the project's own source tree for building, which is normal AUR practice; the external package addition is declared in the PKGBUILD and part of the build process, not an undeclared dependency injection.

1 higher static finding superseded - not the current verdict (shown for transparency)

MEDIUM npm/yarn/pnpm install of an undeclared external package npm_install_external

Runs `npm/yarn/pnpm install <package>` for a package not in source=(), pulling unpinned, unreviewed code at build time. Severity downgraded: the package declares/looks like a Node.js consumer, where build-time installs are expected.

PKGBUILD:80 NODE_ENV=development npm add -D @electron-forge/plugin-local-electron

PKGBUILD

1 offending line(s) highlighted

      1# Maintainer: zxp19821005 <zxp19821005 at 163 dot com>
    
      2pkgname=bettersoundcloud
    
      3_pkgname=BetterSoundCloud
    
      4pkgver=0.7.1
    
      5_electronversion=32
    
      6_nodeversion=22
    
      7pkgrel=1
    
      8pkgdesc="A PC client of SoundCloud with improvement made using electronjs.(Use system-wide electron)"
    
      9arch=('any')
    
      10url="https://github.com/AlirezaKJ/BetterSoundCloud"
    
      11license=('MIT')
    
      12conflicts=("${pkgname}")
    
      13depends=(
    
  "electron${_electronversion}"
    
      15)
    
      16makedepends=(
    
  'gendesk'
    
  'npm'
    
  'nvm'
    
  'curl'
    
  'git'
    
  'icoutils'
    
  'jq'
    
      24)
    
      25source=(
    
  "${pkgname}-${pkgver}::git+${url}#tag=V${pkgver}"
    
  "${pkgname}.sh"
    
      28)
    
      29sha256sums=('077afce9b3798af59f20f2546925de032dbb9ba2cbe1f4748ac6ccb85969678b'
    
          'a774c2f54fbbeeaac3cefc0f7250796d30c86d27f0fd40b7eaf9c0fdb021623d')
    
      31_ensure_local_nvm() {
    
  local NVM_DIR="${srcdir}/.nvm"
    
  source /usr/share/nvm/init-nvm.sh || [[ $? != 1 ]]
    
  nvm install "${_nodeversion}"
    
  nvm use "${_nodeversion}"
    
      36}
    
      37_get_electron_version() {
    
  _elec_ver=$(find "${srcdir}" -maxdepth 5 -name "package.json" ! -path "*/node_modules/*" \
    
      -exec grep -l '"electron"' {} + | xargs -I{} jq -r '(.devDependencies.electron // .dependencies.electron) // empty' {} 2>/dev/null | head -1)
    
  [[ -z "${_elec_ver}" ]] && return 1
    
  echo -e "The electron version is: \033[1;31m${_elec_ver%%.*}\033[0m"
    
      42}
    
      43prepare() {
    
  cd "${srcdir}/${pkgname}-${pkgver}"
    
  _get_electron_version
    
  sed -i -e "
    
      s/@electronversion@/${_electronversion}/g
    
      s/@appname@/${pkgname}/g
    
      s/@runname@/app.asar/g
    
      s/@cfgdirname@/${pkgname}/g
    
  " "${srcdir}/${pkgname}.sh"
    
  gendesk -q -f -n \
    
      --pkgname="${pkgname}" \
    
      --pkgdesc="${pkgdesc}" \
    
      --categories="AudioVideo" \
    
      --name="${_pkgname}" \
    
      --exec="${pkgname} %U"
    
  export ELECTRON_SKIP_BINARY_DOWNLOAD=1
    
  export SYSTEM_ELECTRON_VERSION="$(electron${_electronversion} -v | sed 's/v//g')"
    
  local HOME="${srcdir}/.electron-gyp"
    
  export NPM_CONFIG_CACHE="${srcdir}/.npm_cache"
    
  export NPM_CONFIG_MAXSOCKETS=32
    
  if [[ "$(curl -s ipinfo.io/country)" == *"CN"* ]]; then
    
      {
    
          export NPM_CONFIG_REGISTRY="https://registry.npmmirror.com"
    
          export NPM_CONFIG_ELECTRON_MIRROR="https://registry.npmmirror.com/-/binary/electron/"
    
          export NPM_CONFIG_ELECTRON_BUILDER_BINARIES_MIRROR="https://registry.npmmirror.com/-/binary/electron-builder-binaries/"
    
          export NODEJS_ORG_MIRROR="https://npmmirror.com/mirrors/node"
    
          export ELECTRON_MIRROR="https://npmmirror.com/mirrors/electron/"
    
          export ELECTRON_BUILDER_BINARIES_MIRROR="https://npmmirror.com/mirrors/electron-builder-binaries/"
    
      }
    
      find ./ -type f -name "package-lock.json" -exec sed -i "s/registry.npmjs.org/registry.npmmirror.com/g" {} +
    
  fi
    
  _ensure_local_nvm
    
  icotool -x app/lib/assets/icon.ico -o app/lib/assets
    
  cp app/lib/assets/icon_1_128x128x32.png app/lib/assets/icon.png
    
  sed -i "s/icon\.ico/icon\.png/g" main.js
    
  sed -i "s/\"electron\": \"[^\"]*\"/\"electron\": \"${SYSTEM_ELECTRON_VERSION}\"/g" package.json
    
  NODE_ENV=development    npm install
    
  NODE_ENV=development    npm add -D @electron-forge/plugin-local-electron
    
      81}
    
      82build() {
    
  cd "${srcdir}/${pkgname}-${pkgver}"
    
  _ensure_local_nvm
    
  local electronDist="/usr/lib/electron${_electronversion}"
    
  sed -i -e "/^[[:space:]]*plugins:[[:space:]]*\[.*\$/a\\
    
  {\\
    
      name: \"@electron-forge/plugin-local-electron\",\\
    
      config: {\\
    
          electronPath: \"${electronDist}\"\\
    
      }\\
    
  }," forge.config.*
    
  NODE_ENV=production     npm run package
    
      94}
    
      95package() {
    
  install -Dm755 "${srcdir}/${pkgname}.sh" "${pkgdir}/usr/bin/${pkgname}"
    
  install -Dm755 -d "${pkgdir}/usr/lib/${pkgname}"
    
  local _app_dir=$(find "${srcdir}" -type f -name "resources.pak" ! -path "*/node_modules/*" -exec dirname {} + | head -n 1)
    
  cp -a "${_app_dir}/resources/". "${pkgdir}/usr/lib/${pkgname}/"
    
  install -Dm644 "${srcdir}/${pkgname}-${pkgver}/${pkgname}.desktop" -t "${pkgdir}/usr/share/applications"
    
  install -Dm644 "${srcdir}/${pkgname}-${pkgver}/app/lib/assets/icon.png" "${pkgdir}/usr/share/pixmaps/${pkgname}.png"
    
  install -Dm644 "${srcdir}/${pkgname}-${pkgver}/package.json" -t "${pkgdir}/usr/share/licenses/${pkgname}"
    
      103}
    
      104

Scan history

Scanned at (UTC)	Severity	Rules
2026-08-03 00:08:14	LOW	2
2026-08-02 00:16:08	LOW	2
2026-08-01 00:11:18	LOW	2
2026-07-31 00:14:10	LOW	2
2026-07-30 00:17:23	LOW	2
2026-07-29 00:25:53	LOW	2
2026-07-28 00:07:28	LOW	2
2026-07-27 00:24:32	LOW	2
2026-07-26 00:07:32	LOW	2
2026-07-25 00:13:44	LOW	2
2026-07-24 00:02:28	LOW	2
2026-07-23 00:14:47	LOW	2
2026-07-22 00:29:32	LOW	2
2026-07-21 00:24:15	LOW	2
2026-07-20 00:19:49	LOW	2
2026-07-19 00:17:08	LOW	2
2026-07-18 00:14:48	LOW	2
2026-07-17 00:06:16	LOW	2
2026-07-16 00:05:41	LOW	2
2026-07-15 00:09:25	LOW	2