electerm

MEDIUM

maintainer zxp19821005 1 votes scanned 2026-11-01 00:21:48.120785

View on AUR

Why flagged

The PKGBUILD runs 'npm install' and 'npm add -D node-gyp' in prepare(), installing undeclared dependencies from the npm registry, which could introduce unreviewed remote code during build time.

Triggered rules

Medium npm/yarn/pnpm install of an undeclared external package npm_install_external

Runs `npm/yarn/pnpm install <package>` for a package not in source=(), pulling unpinned, unreviewed code at build time. Severity downgraded: the package declares/looks like a Node.js consumer, where build-time installs are expected.

PKGBUILD:97 npm add -D node-gyp

Medium AI review llm_review

An AI model (qwen/qwen3-235b-a22b-2507) reviewed this and agrees it is MEDIUM (confidence 85%): The PKGBUILD runs 'npm install' and 'npm add -D node-gyp' in prepare(), installing undeclared dependencies from the npm registry, which could introduce unreviewed remote code during build time.

PKGBUILD

1 offending line(s) highlighted

      1# Maintainer: zxp19821005 <zxp19821005 at 163 dot com>
    
      2# Contributor: Zaoqi
    
      3pkgname=electerm
    
      4pkgver=5.7.21
    
      5_electronversion=44
    
      6_nodeversion=24
    
      7pkgrel=1
    
      8pkgdesc="Free and open-sourced terminal/ssh/sftp/ftp/telnet/serialport/RDP/VNC/Spice client."
    
      9arch=(
    
      10    'aarch64'
    
      11    'x86_64'
    
      12)
    
      13url="https://electerm.org/"
    
      14_ghurl="https://github.com/electerm/electerm"
    
      15license=('MIT')
    
      16conflicts=("${pkgname}")
    
      17depends=(
    
      18    "electron${_electronversion}"
    
      19)
    
      20makedepends=(
    
      21    'npm'
    
      22    'nvm'
    
      23    'gendesk'
    
      24    'python-setuptools'
    
      25    'git'
    
      26    'jq'
    
      27)
    
      28source=(
    
      29    "${pkgname}-${pkgver}.tar.gz::${_ghurl}/archive/refs/tags/v${pkgver}.tar.gz"
    
      30    "${pkgname}.js"
    
      31    "${pkgname}.sh"
    
      32)
    
      33sha256sums=('229aac07763ebca5915826e3697334048013c2487c7401a2082898a6ae83ff11'
    
      34            '562897be8a17076176f8d985c0d7bc1c685f2e7c9b3a932339ce015963243627'
    
      35            '0f4675ddc96a032accf82723c7b6b66007bafd18aa8d919b61e983a68fd25328')
    
      36_get_project_dir() {
    
      37	local d
    
      38	while IFS= read -r d; do
    
      39		find "$d" -name "package.json" ! -path "*/node_modules/*" 2>/dev/null | grep -q . && { echo "$d"; return; }
    
      40	done < <(find "${srcdir}" -maxdepth 1 -mindepth 1 -type d ! -name '.*')
    
      41}
    
      42_ensure_local_nvm() {
    
      43	local NVM_DIR="${srcdir}/.nvm"
    
      44	source /usr/share/nvm/init-nvm.sh || [[ $? != 1 ]]
    
      45	nvm install "${_nodeversion}"
    
      46	nvm use "${_nodeversion}"
    
      47}
    
      48_get_app_dir() {
    
      49	find "${srcdir}" -type f -name "resources.pak" ! -path "*/node_modules/*" -printf '%h\n' 2>/dev/null \
    
      50		| while read -r d; do [[ -d "${d}/resources" ]] && { echo "$d"; return 0; }; done
    
      51}
    
      52_get_electron_version() {
    
      53	_elec_ver=$(find "$(_get_project_dir)" -name "package.json" ! -path "*/node_modules/*" -print \
    
      54		| xargs -I{} jq -r '(.devDependencies.electron // .dependencies.electron) // empty' {} 2>/dev/null \
    
      55		| grep -oE '[0-9]+' | head -1)
    
      56	[[ -z "${_elec_ver}" ]] && return 1
    
      57	(( _elec_ver == _electronversion )) && c=32 || c=31
    
      58	echo -e "Electron version: \033[1;${c}m${_elec_ver}$([[ $c -eq 31 ]] && echo " (expected ${_electronversion})")\033[0m"
    
      59}
    
      60_set_build_env() {
    
      61	export ELECTRON_DIST="/usr/lib/electron${_electronversion}"
    
      62	export ELECTRON_OVERRIDE_DIST_PATH="${ELECTRON_DIST}"
    
      63	export ELECTRON_SKIP_BINARY_DOWNLOAD=1
    
      64	export ELECTRON_BUILDER_OFFLINE=true
    
      65	export SYSTEM_ELECTRON_VERSION="$(electron${_electronversion} -v | sed 's/^v//')"
    
      66	export HOME="${srcdir}/.home"
    
      67	export XDG_CACHE_HOME="${HOME}/.cache"
    
      68	export XDG_CONFIG_HOME="${HOME}/.config"
    
      69	export XDG_DATA_HOME="${HOME}/.local/share"
    
      70	export npm_config_cache="${HOME}/.npm_cache"
    
      71	export COREPACK_NPM_REGISTRY="${COREPACK_NPM_REGISTRY:-${NPM_CONFIG_REGISTRY:-https://registry.npmjs.org}}"
    
      72	export COREPACK_HOME="${HOME}/.corepack"
    
      73	export npm_config_audit=false
    
      74	export npm_config_registry="${NPM_CONFIG_REGISTRY:-${npm_config_registry:-https://registry.npmjs.org}}"
    
      75	mkdir -p "${HOME}" "${npm_config_cache}" "${COREPACK_HOME}"
    
      76}
    
      77prepare() {
    
      78    cd "$(_get_project_dir)"
    
      79    _get_electron_version
    
      80    sed -i -e "
    
      81        s/@electronversion@/${_electronversion}/g
    
      82        s/@appname@/${pkgname}/g
    
      83    " "${srcdir}/${pkgname}.sh" "${srcdir}/${pkgname}.js"
    
      84    gendesk -q -f -n \
    
      85        --pkgname="${pkgname}" \
    
      86        --pkgdesc="${pkgdesc}" \
    
      87        --categories="System" \
    
      88        --name="${pkgname}" \
    
      89        --exec="${pkgname} %U"
    
      90    _ensure_local_nvm
    
      91    _set_build_env
    
      92    jq --arg ver "${SYSTEM_ELECTRON_VERSION}" '.devDependencies.electron = $ver' package.json > package.json.tmp && mv package.json.tmp package.json
    
      93    find ./ -type f -name "package-lock.json" -exec rm {} +
    
      94    export NODE_ENV=development
    
      95    npm config set legacy-peer-deps true
    
      96    npm install
    
      97    npm add -D node-gyp
    
      98}
    
      99build() {
    
      100    cd "$(_get_project_dir)"
    
      101    _ensure_local_nvm
    
      102    _set_build_env
    
      103    export NODE_ENV=production
    
      104    npm run clean
    
      105    npm run compile
    
      106    npm run prepare-file
    
      107    WORKFLOW_NAME=linux-pkgbuild npm exec -c "electron-builder --linux dir -c.electronDist=${ELECTRON_DIST} --config src/build/electron-builder.json"
    
      108    find "$(_get_app_dir)/resources" -type d -exec chmod 755 {} +
    
      109	local _archrem=$([[ "${CARCH}" == "aarch64" ]] && echo x64 || echo arm)
    
      110	find "$(_get_app_dir)" -type d \
    
      111		\( -name '*darwin*' -o -name '*android*' -o -name 'win32*' -o -name "*ia32*" -o -name "*${_archrem}*" \) \
    
      112		-prune -exec rm -rf {} +
    
      113    rm -rf "$(_get_project_dir)/resources/default_app.asar"
    
      114}
    
      115package() {
    
      116    install -Dm755 "${srcdir}/${pkgname}.sh" "${pkgdir}/usr/bin/${pkgname}"
    
      117    install -Dm644 "${srcdir}/${pkgname}.js" -t "${pkgdir}/usr/lib/${pkgname}"
    
      118	cp -a "$(_get_app_dir)/resources/." "${pkgdir}/usr/lib/${pkgname}/"
    
      119    install -Dm644 "$(_get_project_dir)/node_modules/@${pkgname}/${pkgname}-resource/build-res/appx/StoreLogo.png" \
    
      120        "${pkgdir}/usr/share/pixmaps/${pkgname}.png"
    
      121    install -Dm644 "$(_get_project_dir)/${pkgname}.desktop" -t "${pkgdir}/usr/share/applications"
    
      122    install -Dm644 "$(_get_project_dir)/LICENSE" -t "${pkgdir}/usr/share/licenses/${pkgname}"
    
      123}
    
      124

Changes since previous scan

--- PKGBUILD @ 2026-10-29 00:13
+++ PKGBUILD @ 2026-11-01 00:21
@@ -1,14 +1,13 @@
 # Maintainer: zxp19821005 <zxp19821005 at 163 dot com>
 # Contributor: Zaoqi
 pkgname=electerm
-pkgver=5.7.15
+pkgver=5.7.21
 _electronversion=44
 _nodeversion=24
 pkgrel=1
 pkgdesc="Free and open-sourced terminal/ssh/sftp/ftp/telnet/serialport/RDP/VNC/Spice client."
 arch=(
     'aarch64'
-    'armv7h'
     'x86_64'
 )
 url="https://electerm.org/"
@@ -28,10 +27,12 @@
 )
 source=(
     "${pkgname}-${pkgver}.tar.gz::${_ghurl}/archive/refs/tags/v${pkgver}.tar.gz"
+    "${pkgname}.js"
     "${pkgname}.sh"
 )
-sha256sums=('c30878362ba37708e6efd1f6ece334b3d9ad65510f04628c6485d173cbacafdc'
-            '983ddfde8e06d067be65dd41ccc555f4da0a635358eac915c40863d0782206c7')
+sha256sums=('229aac07763ebca5915826e3697334048013c2487c7401a2082898a6ae83ff11'
+            '562897be8a17076176f8d985c0d7bc1c685f2e7c9b3a932339ce015963243627'
+            '0f4675ddc96a032accf82723c7b6b66007bafd18aa8d919b61e983a68fd25328')
 _get_project_dir() {
 	local d
 	while IFS= read -r d; do
@@ -79,7 +80,7 @@
     sed -i -e "
         s/@electronversion@/${_electronversion}/g
         s/@appname@/${pkgname}/g
-    " "${srcdir}/${pkgname}.sh"
+    " "${srcdir}/${pkgname}.sh" "${srcdir}/${pkgname}.js"
     gendesk -q -f -n \
         --pkgname="${pkgname}" \
         --pkgdesc="${pkgdesc}" \
@@ -113,7 +114,7 @@
 }
 package() {
     install -Dm755 "${srcdir}/${pkgname}.sh" "${pkgdir}/usr/bin/${pkgname}"
-    install -Dm755 -d "${pkgdir}/usr/lib/${pkgname}"
+    install -Dm644 "${srcdir}/${pkgname}.js" -t "${pkgdir}/usr/lib/${pkgname}"
 	cp -a "$(_get_app_dir)/resources/." "${pkgdir}/usr/lib/${pkgname}/"
     install -Dm644 "$(_get_project_dir)/node_modules/@${pkgname}/${pkgname}-resource/build-res/appx/StoreLogo.png" \
         "${pkgdir}/usr/share/pixmaps/${pkgname}.png"

Scan history

Scanned at (UTC)	Severity	Rules
2026-11-01 00:21:48	Medium	2
2026-10-31 00:07:41	Medium	2
2026-10-30 03:55:04	Medium	2
2026-10-30 00:29:30	Medium	2
2026-10-29 05:51:59	Medium	2
2026-10-29 00:13:55	Low	2
2026-10-28 00:06:54	Low	2
2026-10-27 00:23:28	Low	2
2026-10-26 09:44:33	Medium	1
2026-10-26 00:12:40	Low	2
2026-10-25 00:20:48	Low	2
2026-10-24 00:14:55	Low	2
2026-10-23 00:02:19	Low	2
2026-10-22 00:13:10	Low	2
2026-10-21 00:12:50	Low	2
2026-10-20 07:27:55	Medium	1
2026-10-20 00:10:31	Low	2
2026-10-19 00:03:55	Low	2
2026-10-18 00:06:55	Low	2
2026-10-17 00:21:55	Low	2