electerm-git

LOW

maintainer zxp19821005 0 votes scanned 2026-11-01 00:21:48.120785

View on AUR

Why flagged

The npm install runs in the project's own source directory during prepare(), which is standard for building the application; it installs declared dependencies from the project's package.json, not an undeclared external package, so the flagged pattern is a false positive.

Triggered rules

Low AI review downgraded a static finding llm_review

The static rules flagged this MEDIUM, but an AI model (qwen/qwen3-235b-a22b-2507) reviewed the full PKGBUILD and judged it LOW (confidence 95%): The npm install runs in the project's own source directory during prepare(), which is standard for building the application; it installs declared dependencies from the project's package.json, not an undeclared external package, so the flagged pattern is a false positive.

1 higher static finding superseded - not the current verdict (shown for transparency)

Medium npm/yarn/pnpm install of an undeclared external package npm_install_external

Runs `npm/yarn/pnpm install <package>` for a package not in source=(), pulling unpinned, unreviewed code at build time. Severity downgraded: the package declares/looks like a Node.js consumer, where build-time installs are expected.

PKGBUILD:103 npm add -D node-gyp --legacy-peer-deps

PKGBUILD

1 offending line(s) highlighted

      1# Maintainer: zxp19821005 <zxp19821005 at 163 dot com>
    
      2pkgname=electerm-git
    
      3pkgver=5.7.21.r11.gd16a354
    
      4_electronversion=44
    
      5_nodeversion=24
    
      6pkgrel=1
    
      7pkgdesc="Free and open-sourced terminal/ssh/sftp/ftp/telnet/serialport/RDP/VNC/Spice client."
    
      8arch=(
    
      9    'aarch64'
    
      10    'x86_64'
    
      11)
    
      12url="https://electerm.html5beta.com/"
    
      13_ghurl="https://github.com/electerm/electerm"
    
      14license=('MIT')
    
      15conflicts=("${pkgname%-git}")
    
      16provides=("${pkgname%-git}=${pkgver%.r*}")
    
      17depends=(
    
      18    "electron${_electronversion}"
    
      19)
    
      20makedepends=(
    
      21    'npm'
    
      22    'git'
    
      23    'nvm'
    
      24    'gendesk'
    
      25    'python-setuptools'
    
      26    'jq'
    
      27)
    
      28source=(
    
      29    "${pkgname//-/.}::git+${_ghurl}.git"
    
      30    "${pkgname%-git}.js"
    
      31    "${pkgname%-git}.sh"
    
      32)
    
      33sha256sums=('SKIP'
    
      34            '562897be8a17076176f8d985c0d7bc1c685f2e7c9b3a932339ce015963243627'
    
      35            '0f4675ddc96a032accf82723c7b6b66007bafd18aa8d919b61e983a68fd25328')
    
      36_get_project_dir() {
    
      37	local d
    
      38	while IFS= read -r d; do
    
      39		find "$d" -name "package.json" ! -path "*/node_modules/*" 2>/dev/null | grep -q . && { echo "$d"; return; }
    
      40	done < <(find "${srcdir}" -maxdepth 1 -mindepth 1 -type d ! -name '.*')
    
      41}
    
      42pkgver() {
    
      43	cd "$(_get_project_dir)"
    
      44	set -o pipefail
    
      45	git describe --long --tags --abbrev=7 | sed 's/\([^-]*-g\)/r\1/;s/-/./g;s/v//g' ||
    
      46	printf "r%s.%s" "$(git rev-list --count HEAD)" "$(git rev-parse --short=7 HEAD)"
    
      47}
    
      48_ensure_local_nvm() {
    
      49	local NVM_DIR="${srcdir}/.nvm"
    
      50	source /usr/share/nvm/init-nvm.sh || [[ $? != 1 ]]
    
      51	nvm install "${_nodeversion}"
    
      52	nvm use "${_nodeversion}"
    
      53}
    
      54_get_app_dir() {
    
      55	find "${srcdir}" -type f -name "resources.pak" ! -path "*/node_modules/*" -printf '%h\n' 2>/dev/null \
    
      56		| while read -r d; do [[ -d "${d}/resources" ]] && { echo "$d"; return 0; }; done
    
      57}
    
      58_get_electron_version() {
    
      59	_elec_ver=$(find "$(_get_project_dir)" -name "package.json" ! -path "*/node_modules/*" -print \
    
      60		| xargs -I{} jq -r '(.devDependencies.electron // .dependencies.electron) // empty' {} 2>/dev/null \
    
      61		| grep -oE '[0-9]+' | head -1)
    
      62	[[ -z "${_elec_ver}" ]] && return 1
    
      63	(( _elec_ver == _electronversion )) && c=32 || c=31
    
      64	echo -e "Electron version: \033[1;${c}m${_elec_ver}$([[ $c -eq 31 ]] && echo " (expected ${_electronversion})")\033[0m"
    
      65}
    
      66_set_build_env() {
    
      67	export ELECTRON_DIST="/usr/lib/electron${_electronversion}"
    
      68	export ELECTRON_OVERRIDE_DIST_PATH="${ELECTRON_DIST}"
    
      69	export ELECTRON_SKIP_BINARY_DOWNLOAD=1
    
      70	export ELECTRON_BUILDER_OFFLINE=true
    
      71	export SYSTEM_ELECTRON_VERSION="$(electron${_electronversion} -v | sed 's/^v//')"
    
      72	export HOME="${srcdir}/.home"
    
      73	export XDG_CACHE_HOME="${HOME}/.cache"
    
      74	export XDG_CONFIG_HOME="${HOME}/.config"
    
      75	export XDG_DATA_HOME="${HOME}/.local/share"
    
      76	export npm_config_cache="${HOME}/.npm_cache"
    
      77	export COREPACK_NPM_REGISTRY="${COREPACK_NPM_REGISTRY:-${NPM_CONFIG_REGISTRY:-https://registry.npmjs.org}}"
    
      78	export COREPACK_HOME="${HOME}/.corepack"
    
      79	export npm_config_audit=false
    
      80	export npm_config_registry="${NPM_CONFIG_REGISTRY:-${npm_config_registry:-https://registry.npmjs.org}}"
    
      81	mkdir -p "${HOME}" "${npm_config_cache}" "${COREPACK_HOME}"
    
      82}
    
      83prepare() {
    
      84    cd "$(_get_project_dir)"
    
      85    _get_electron_version
    
      86    sed -i -e "
    
      87        s/@electronversion@/${_electronversion}/g
    
      88        s/@appname@/${pkgname%-git}/g
    
      89    " "${srcdir}/${pkgname%-git}.sh" "${srcdir}/${pkgname%-git}.js"
    
      90    gendesk -q -f -n \
    
      91        --pkgname="${pkgname%-git}" \
    
      92        --pkgdesc="${pkgdesc}" \
    
      93        --categories="System" \
    
      94        --name="${pkgname%-git}" \
    
      95        --exec="${pkgname%-git} %U"
    
      96    _ensure_local_nvm
    
      97    _set_build_env
    
      98    jq --arg ver "${SYSTEM_ELECTRON_VERSION}" '.devDependencies.electron = $ver' package.json > package.json.tmp && mv package.json.tmp package.json
    
      99    find ./ -type f -name "package-lock.json" -exec rm {} +
    
      100    export NODE_ENV=development
    
      101    npm config set legacy-peer-deps true
    
      102    npm install --legacy-peer-deps
    
      103    npm add -D node-gyp --legacy-peer-deps
    
      104}
    
      105build() {
    
      106    cd "$(_get_project_dir)"
    
      107    _set_build_env
    
      108    _ensure_local_nvm
    
      109    export NODE_ENV=production
    
      110    npm run clean
    
      111    npm run compile
    
      112    npm run prepare-file
    
      113    WORKFLOW_NAME=linux-pkgbuild npm exec -c "electron-builder --linux dir -c.electronDist=${ELECTRON_DIST} --config src/build/electron-builder.json"
    
      114    find "$(_get_app_dir)/resources" -type d -exec chmod 755 {} +
    
      115    local _archrem=$([[ "${CARCH}" == "aarch64" ]] && echo x64 || echo arm)
    
      116	find "$(_get_app_dir)" -type d \
    
      117		\( -name '*darwin*' -o -name '*android*' -o -name 'win32*' -o -name "*ia32*" -o -name "*${_archrem}*" \) \
    
      118		-prune -exec rm -rf {} +
    
      119    rm -rf "$(_get_app_dir)/resources/default_app.asar"
    
      120}
    
      121package() {
    
      122    install -Dm755 "${srcdir}/${pkgname%-git}.sh" "${pkgdir}/usr/bin/${pkgname%-git}"
    
      123    install -Dm644 "${srcdir}/${pkgname%-git}.js" -t "${pkgdir}/usr/lib/${pkgname%-git}"
    
      124    cp -a "$(_get_app_dir)/resources/." "${pkgdir}/usr/lib/${pkgname%-git}/"
    
      125    _icon_sizes=(16x16 24x24 32x32 48x48 64x64 128x128 256x256 512x512 1024x1024)
    
      126	for _icons in "${_icon_sizes[@]}";do
    
      127		install -Dm644 "$(_get_project_dir)/node_modules/@electerm/electerm-resource/build-res/linux/${_icons}.png" \
    
      128			"${pkgdir}/usr/share/icons/hicolor/${_icons}/apps/${pkgname%-git}.png"
    
      129	done
    
      130    install -Dm644 "$(_get_project_dir)/${pkgname%-git}.desktop" -t "${pkgdir}/usr/share/applications"
    
      131    install -Dm644 "$(_get_project_dir)/LICENSE" -t "${pkgdir}/usr/share/licenses/${pkgname}"
    
      132}
    
      133

Changes since previous scan

--- PKGBUILD @ 2026-10-29 00:13
+++ PKGBUILD @ 2026-11-01 00:21
@@ -1,13 +1,12 @@
 # Maintainer: zxp19821005 <zxp19821005 at 163 dot com>
 pkgname=electerm-git
-pkgver=5.7.15.r0.gc1de836
+pkgver=5.7.21.r11.gd16a354
 _electronversion=44
 _nodeversion=24
 pkgrel=1
 pkgdesc="Free and open-sourced terminal/ssh/sftp/ftp/telnet/serialport/RDP/VNC/Spice client."
 arch=(
     'aarch64'
-    'armv7h'
     'x86_64'
 )
 url="https://electerm.html5beta.com/"
@@ -28,10 +27,12 @@
 )
 source=(
     "${pkgname//-/.}::git+${_ghurl}.git"
+    "${pkgname%-git}.js"
     "${pkgname%-git}.sh"
 )
 sha256sums=('SKIP'
-            'dfcd6603d29c7b8d88e019b517a2e5c1a7b5ab905a0961a8b81adfa508b258b8')
+            '562897be8a17076176f8d985c0d7bc1c685f2e7c9b3a932339ce015963243627'
+            '0f4675ddc96a032accf82723c7b6b66007bafd18aa8d919b61e983a68fd25328')
 _get_project_dir() {
 	local d
 	while IFS= read -r d; do
@@ -85,7 +86,7 @@
     sed -i -e "
         s/@electronversion@/${_electronversion}/g
         s/@appname@/${pkgname%-git}/g
-    " "${srcdir}/${pkgname%-git}.sh"
+    " "${srcdir}/${pkgname%-git}.sh" "${srcdir}/${pkgname%-git}.js"
     gendesk -q -f -n \
         --pkgname="${pkgname%-git}" \
         --pkgdesc="${pkgdesc}" \
@@ -96,8 +97,7 @@
     _set_build_env
     jq --arg ver "${SYSTEM_ELECTRON_VERSION}" '.devDependencies.electron = $ver' package.json > package.json.tmp && mv package.json.tmp package.json
     find ./ -type f -name "package-lock.json" -exec rm {} +
-    export NODE_ENV=developmentgit clone git+ssh://aur@aur.archlinux.org/electerm-git && cd electerm-git && touch PKGBUILD electerm.sh
-
+    export NODE_ENV=development
     npm config set legacy-peer-deps true
     npm install --legacy-peer-deps
     npm add -D node-gyp --legacy-peer-deps
@@ -120,7 +120,7 @@
 }
 package() {
     install -Dm755 "${srcdir}/${pkgname%-git}.sh" "${pkgdir}/usr/bin/${pkgname%-git}"
-    install -Dm755 -d "${pkgdir}/usr/lib/${pkgname%-git}"
+    install -Dm644 "${srcdir}/${pkgname%-git}.js" -t "${pkgdir}/usr/lib/${pkgname%-git}"
     cp -a "$(_get_app_dir)/resources/." "${pkgdir}/usr/lib/${pkgname%-git}/"
     _icon_sizes=(16x16 24x24 32x32 48x48 64x64 128x128 256x256 512x512 1024x1024)
 	for _icons in "${_icon_sizes[@]}";do

Scan history

Scanned at (UTC)	Severity	Rules
2026-11-01 00:21:48	Low	2
2026-10-31 00:07:41	Low	2
2026-10-30 00:29:30	Low	2
2026-10-29 05:51:59	Medium	1
2026-10-29 00:13:55	Low	2
2026-10-28 00:06:54	Low	2
2026-10-27 00:23:28	Low	2
2026-10-26 09:44:33	Medium	1
2026-10-26 00:12:40	Low	2
2026-10-25 00:20:48	Low	2
2026-10-24 00:14:55	Low	2
2026-10-23 00:02:19	Low	2
2026-10-22 00:13:10	Low	2
2026-10-21 00:12:50	Low	2
2026-10-20 07:27:55	Medium	1
2026-10-20 00:10:31	Low	2
2026-10-19 00:03:55	Low	2
2026-10-18 00:06:55	Low	2
2026-10-17 00:21:55	Low	2
2026-10-16 00:12:47	Low	2