hihat-git

LOW

maintainer zxp19821005 0 votes scanned 2026-11-01 00:21:48.120785

View on AUR

Why flagged

The npx execution is part of the project's own build process (ts-node clean.js), running a local script from the source tree, not an arbitrary remote package.

Triggered rules

Low AI review downgraded a static finding llm_review

The static rules flagged this MEDIUM, but an AI model (qwen/qwen3-235b-a22b-2507) reviewed the full PKGBUILD and judged it LOW (confidence 95%): The npx execution is part of the project's own build process (ts-node clean.js), running a local script from the source tree, not an arbitrary remote package.

1 higher static finding superseded - not the current verdict (shown for transparency)

Medium npx/bunx/deno executes a remote package remote_code_tool

`npx`/`bunx`/`pnpm dlx`/`deno run <url>` downloads AND runs a remote package at build time — the moral equivalent of piping a download into a shell. Severity downgraded: Node.js consumer context.

PKGBUILD:103 npx ts-node ./.erb/scripts/clean.js dist

PKGBUILD

1 offending line(s) highlighted

      1# Maintainer: zxp19821005 <zxp19821005 at 163 dot com>
    
      2pkgname=hihat-git
    
      3pkgver=2.4.0.r0.g11b93cb
    
      4_electronversion=42
    
      5_nodeversion=24
    
      6pkgrel=1
    
      7pkgdesc="A free, open-source, and modern music player for local libraries. No ads, no accounts, no internet — just your music."
    
      8arch=('any')
    
      9url="https://github.com/johnnyshankman/hihat"
    
      10license=('MIT')
    
      11conflicts=("${pkgname%-git}")
    
      12provides=("${pkgname%-git}")
    
      13depends=(
    
      14    "electron${_electronversion}"
    
      15)
    
      16makedepends=(
    
      17    'gendesk'
    
      18    'git'
    
      19    'nvm'
    
      20    'npm'
    
      21    'jq'
    
      22)
    
      23source=(
    
      24    "${pkgname//-/.}::git+${url}.git"
    
      25    "${pkgname%-git}.js"
    
      26    "${pkgname%-git}.sh"
    
      27)
    
      28sha256sums=('SKIP'
    
      29            '562897be8a17076176f8d985c0d7bc1c685f2e7c9b3a932339ce015963243627'
    
      30            '0f4675ddc96a032accf82723c7b6b66007bafd18aa8d919b61e983a68fd25328')
    
      31_get_project_dir() {
    
      32	local d
    
      33	while IFS= read -r d; do
    
      34		find "$d" -name "package.json" ! -path "*/node_modules/*" 2>/dev/null | grep -q . && { echo "$d"; return; }
    
      35	done < <(find "${srcdir}" -maxdepth 1 -mindepth 1 -type d ! -name '.*')
    
      36}
    
      37pkgver() {
    
      38	cd "$(_get_project_dir)"
    
      39	set -o pipefail
    
      40	git describe --long --tags --abbrev=7 | sed 's/\([^-]*-g\)/r\1/;s/-/./g;s/v//g' ||
    
      41	printf "r%s.%s" "$(git rev-list --count HEAD)" "$(git rev-parse --short=7 HEAD)"
    
      42}
    
      43_ensure_local_nvm() {
    
      44	local NVM_DIR="${srcdir}/.nvm"
    
      45	source /usr/share/nvm/init-nvm.sh || [[ $? != 1 ]]
    
      46	nvm install "${_nodeversion}"
    
      47	nvm use "${_nodeversion}"
    
      48}
    
      49_get_app_dir() {
    
      50	find "${srcdir}" -type f -name "resources.pak" ! -path "*/node_modules/*" -printf '%h\n' 2>/dev/null \
    
      51		| while read -r d; do [[ -d "${d}/resources" ]] && { echo "$d"; return 0; }; done
    
      52}
    
      53_get_electron_version() {
    
      54	_elec_ver=$(find "$(_get_project_dir)" -name "package.json" ! -path "*/node_modules/*" -print \
    
      55		| xargs -I{} jq -r '(.devDependencies.electron // .dependencies.electron) // empty' {} 2>/dev/null \
    
      56		| grep -oE '[0-9]+' | head -1)
    
      57	[[ -z "${_elec_ver}" ]] && return 1
    
      58	(( _elec_ver == _electronversion )) && c=32 || c=31
    
      59	echo -e "Electron version: \033[1;${c}m${_elec_ver}$([[ $c -eq 31 ]] && echo " (expected ${_electronversion})")\033[0m"
    
      60}
    
      61_set_build_env() {
    
      62	export ELECTRON_DIST="/usr/lib/electron${_electronversion}"
    
      63	export ELECTRON_OVERRIDE_DIST_PATH="${ELECTRON_DIST}"
    
      64	export ELECTRON_SKIP_BINARY_DOWNLOAD=1
    
      65	export ELECTRON_BUILDER_OFFLINE=true
    
      66	export SYSTEM_ELECTRON_VERSION="$(electron${_electronversion} -v | sed 's/^v//')"
    
      67	export HOME="${srcdir}/.home"
    
      68	export XDG_CACHE_HOME="${HOME}/.cache"
    
      69	export XDG_CONFIG_HOME="${HOME}/.config"
    
      70	export XDG_DATA_HOME="${HOME}/.local/share"
    
      71	export npm_config_cache="${HOME}/.npm_cache"
    
      72	export COREPACK_NPM_REGISTRY="${COREPACK_NPM_REGISTRY:-${NPM_CONFIG_REGISTRY:-https://registry.npmjs.org}}"
    
      73	export COREPACK_HOME="${HOME}/.corepack"
    
      74	export npm_config_audit=false
    
      75	export npm_config_registry="${NPM_CONFIG_REGISTRY:-${npm_config_registry:-https://registry.npmjs.org}}"
    
      76	mkdir -p "${HOME}" "${npm_config_cache}" "${COREPACK_HOME}"
    
      77}
    
      78prepare() {
    
      79    cd "$(_get_project_dir)"
    
      80    _get_electron_version
    
      81    sed -i -e "
    
      82        s/@electronversion@/${_electronversion}/g
    
      83        s/@appname@/${pkgname%-git}/g
    
      84    " "${srcdir}/${pkgname%-git}.sh" "${srcdir}/${pkgname%-git}.js"
    
      85    gendesk -q -f -n \
    
      86        --pkgname="${pkgname%-git}" \
    
      87        --pkgdesc="${pkgdesc}" \
    
      88        --categories="AudioVideo" \
    
      89        --name="${pkgname%-git}" \
    
      90        --exec="${pkgname%-git} %U"
    
      91    _ensure_local_nvm
    
      92    _set_build_env
    
      93    jq --arg ver "${SYSTEM_ELECTRON_VERSION}" '.devDependencies.electron = $ver' package.json > package.json.tmp && mv package.json.tmp package.json
    
      94    export NODE_ENV=development
    
      95    npm install --legacy-peer-deps
    
      96}
    
      97build() {
    
      98    cd "$(_get_project_dir)"
    
      99    _ensure_local_nvm
    
      100    _set_build_env
    
      101    export NODE_ENV=production
    
      102    npm run lint
    
      103    npx ts-node ./.erb/scripts/clean.js dist
    
      104    npm run build
    
      105    npm exec -c "electron-builder --linux dir -c.electronDist=${ELECTRON_DIST}"
    
      106    rm -rf "$(_get_app_dir)/resources/default_app.asar"
    
      107}
    
      108package() {
    
      109    install -Dm755 "${srcdir}/${pkgname%-git}.sh" "${pkgdir}/usr/bin/${pkgname%-git}"
    
      110    install -Dm644 "${srcdir}/${pkgname%-git}.js" -t "${pkgdir}/usr/lib/${pkgname%-git}"
    
      111	cp -a "$(_get_app_dir)/resources/." "${pkgdir}/usr/lib/${pkgname%-git}/"
    
      112    install -Dm644 "$(_get_project_dir)/icon.png" "${pkgdir}/usr/share/icons/hicolor/${_icons}/apps/${pkgname%-git}.png"
    
      113    install -Dm644 "$(_get_project_dir)/${pkgname%-git}.desktop" -t "${pkgdir}/usr/share/applications"
    
      114    install -Dm644 "$(_get_project_dir)/LICENSE" -t "${pkgdir}/usr/share/licenses/${pkgname}"
    
      115}
    
      116

Changes since previous scan

--- PKGBUILD @ 2026-10-29 00:13
+++ PKGBUILD @ 2026-11-01 00:21
@@ -1,6 +1,6 @@
 # Maintainer: zxp19821005 <zxp19821005 at 163 dot com>
 pkgname=hihat-git
-pkgver=2.3.6.r5.gc72bf7e
+pkgver=2.4.0.r0.g11b93cb
 _electronversion=42
 _nodeversion=24
 pkgrel=1
@@ -18,60 +18,70 @@
     'git'
     'nvm'
     'npm'
-    'curl'
     'jq'
 )
 source=(
     "${pkgname//-/.}::git+${url}.git"
+    "${pkgname%-git}.js"
     "${pkgname%-git}.sh"
 )
 sha256sums=('SKIP'
-            'a774c2f54fbbeeaac3cefc0f7250796d30c86d27f0fd40b7eaf9c0fdb021623d')
+            '562897be8a17076176f8d985c0d7bc1c685f2e7c9b3a932339ce015963243627'
+            '0f4675ddc96a032accf82723c7b6b66007bafd18aa8d919b61e983a68fd25328')
+_get_project_dir() {
+	local d
+	while IFS= read -r d; do
+		find "$d" -name "package.json" ! -path "*/node_modules/*" 2>/dev/null | grep -q . && { echo "$d"; return; }
+	done < <(find "${srcdir}" -maxdepth 1 -mindepth 1 -type d ! -name '.*')
+}
 pkgver() {
-    cd "${srcdir}/${pkgname//-/.}"
-    set -o pipefail
-    git describe --long --tags --abbrev=7 | sed 's/\([^-]*-g\)/r\1/;s/-/./g;s/v//g' ||
-    printf "r%s.%s" "$(git rev-list --count HEAD)" "$(git rev-parse --short=7 HEAD)"
+	cd "$(_get_project_dir)"
+	set -o pipefail
+	git describe --long --tags --abbrev=7 | sed 's/\([^-]*-g\)/r\1/;s/-/./g;s/v//g' ||
+	printf "r%s.%s" "$(git rev-list --count HEAD)" "$(git rev-parse --short=7 HEAD)"
+}
+_ensure_local_nvm() {
+	local NVM_DIR="${srcdir}/.nvm"
+	source /usr/share/nvm/init-nvm.sh || [[ $? != 1 ]]
+	nvm install "${_nodeversion}"
+	nvm use "${_nodeversion}"
 }
 _get_app_dir() {
-	find "${srcdir}" -type d -name "node_modules" -prune -o -type f -name "resources.pak" -print0 | xargs -0 dirname | head -n 1
+	find "${srcdir}" -type f -name "resources.pak" ! -path "*/node_modules/*" -printf '%h\n' 2>/dev/null \
+		| while read -r d; do [[ -d "${d}/resources" ]] && { echo "$d"; return 0; }; done
+}
+_get_electron_version() {
+	_elec_ver=$(find "$(_get_project_dir)" -name "package.json" ! -path "*/node_modules/*" -print \
+		| xargs -I{} jq -r '(.devDependencies.electron // .dependencies.electron) // empty' {} 2>/dev/null \
+		| grep -oE '[0-9]+' | head -1)
+	[[ -z "${_elec_ver}" ]] && return 1
+	(( _elec_ver == _electronversion )) && c=32 || c=31
+	echo -e "Electron version: \033[1;${c}m${_elec_ver}$([[ $c -eq 31 ]] && echo " (expected ${_electronversion})")\033[0m"
 }
 _set_build_env() {
 	export ELECTRON_DIST="/usr/lib/electron${_electronversion}"
 	export ELECTRON_OVERRIDE_DIST_PATH="${ELECTRON_DIST}"
 	export ELECTRON_SKIP_BINARY_DOWNLOAD=1
+	export ELECTRON_BUILDER_OFFLINE=true
 	export SYSTEM_ELECTRON_VERSION="$(electron${_electronversion} -v | sed 's/^v//')"
 	export HOME="${srcdir}/.home"
-	export XDG_CACHE_HOME="${srcdir}/.cache"
-	export XDG_CONFIG_HOME="${srcdir}/.config"
-	export XDG_DATA_HOME="${srcdir}/.local/share"
-	export npm_config_cache="${srcdir}/.npm_cache"
+	export XDG_CACHE_HOME="${HOME}/.cache"
+	export XDG_CONFIG_HOME="${HOME}/.config"
+	export XDG_DATA_HOME="${HOME}/.local/share"
+	export npm_config_cache="${HOME}/.npm_cache"
 	export COREPACK_NPM_REGISTRY="${COREPACK_NPM_REGISTRY:-${NPM_CONFIG_REGISTRY:-https://registry.npmjs.org}}"
-	export COREPACK_HOME="${srcdir}/.corepack"
+	export COREPACK_HOME="${HOME}/.corepack"
 	export npm_config_audit=false
+	export npm_config_registry="${NPM_CONFIG_REGISTRY:-${npm_config_registry:-https://registry.npmjs.org}}"
 	mkdir -p "${HOME}" "${npm_config_cache}" "${COREPACK_HOME}"
 }
-_ensure_local_nvm() {
-    export NVM_DIR="${srcdir}/.nvm"
-    source /usr/share/nvm/init-nvm.sh || [[ $? != 1 ]]
-    nvm install "${_nodeversion}"
-    nvm use "${_nodeversion}"
-}
-_get_electron_version() {
-    _elec_ver=$(find "${srcdir}" -maxdepth 5 -name "package.json" ! -path "*/node_modules/*" \
-        -exec grep -l '"electron"' {} + | xargs -I{} jq -r '(.devDependencies.electron // .dependencies.electron) // empty' {} 2>/dev/null | head -1)
-    [[ -z "${_elec_ver}" ]] && return 1
-    echo -e "The electron version is: \033[1;31m${_elec_ver%%.*}\033[0m"
-}
 prepare() {
-    cd "${srcdir}/${pkgname//-/.}"
+    cd "$(_get_project_dir)"
     _get_electron_version
     sed -i -e "
         s/@electronversion@/${_electronversion}/g
         s/@appname@/${pkgname%-git}/g
-        s/@runname@/app.asar/g
-        s/@cfgdirname@/${_pkgname}/g
-    " "${srcdir}/${pkgname%-git}.sh"
+    " "${srcdir}/${pkgname%-git}.sh" "${srcdir}/${pkgname%-git}.js"
     gendesk -q -f -n \
         --pkgname="${pkgname%-git}" \
         --pkgdesc="${pkgdesc}" \
@@ -80,13 +90,12 @@
         --exec="${pkgname%-git} %U"
     _ensure_local_nvm
     _set_build_env
-    find src -type f -exec sed -i "s/process.resourcesPath/\'\/usr\/lib\/${pkgname%-git}\'/g" {} +
-    sed -i "s/\"electron\": \"[^\"]*\"/\"electron\": \"${SYSTEM_ELECTRON_VERSION}\"/g" package.json
+    jq --arg ver "${SYSTEM_ELECTRON_VERSION}" '.devDependencies.electron = $ver' package.json > package.json.tmp && mv package.json.tmp package.json
     export NODE_ENV=development
     npm install --legacy-peer-deps
 }
 build() {
-    cd "${srcdir}/${pkgname//-/.}"
+    cd "$(_get_project_dir)"
     _ensure_local_nvm
     _set_build_env
     export NODE_ENV=production
@@ -94,14 +103,14 @@
     npx ts-node ./.erb/scripts/clean.js dist
     npm run build
     npm exec -c "electron-builder --linux dir -c.electronDist=${ELECTRON_DIST}"
+    rm -rf "$(_get_app_dir)/resources/default_app.asar"
 }
 package() {
     install -Dm755 "${srcdir}/${pkgname%-git}.sh" "${pkgdir}/usr/bin/${pkgname%-git}"
-    install -Dm755 -d "${pkgdir}/usr/lib/${pkgname%-git}"
-	local _app_dir=$(_get_app_dir)
-	cp -a "${_app_dir}/resources/." "${pkgdir}/usr/lib/${pkgname%-git}/"
-    rm -rf "${pkgdir}/usr/lib/${pkgname%-git}/default_app.asar"
-    install -Dm644 "${srcdir}/${pkgname//-/.}/icon.png" "${pkgdir}/usr/share/icons/hicolor/${_icons}/apps/${pkgname%-git}.png"
-    install -Dm644 "${srcdir}/${pkgname//-/.}/${pkgname%-git}.desktop" -t "${pkgdir}/usr/share/applications"
-    install -Dm644 "${srcdir}/${pkgname//-/.}/LICENSE" -t "${pkgdir}/usr/share/licenses/${pkgname}"
+    install -Dm644 "${srcdir}/${pkgname%-git}.js" -t "${pkgdir}/usr/lib/${pkgname%-git}"
+	cp -a "$(_get_app_dir)/resources/." "${pkgdir}/usr/lib/${pkgname%-git}/"
+    install -Dm644 "$(_get_project_dir)/icon.png" "${pkgdir}/usr/share/icons/hicolor/${_icons}/apps/${pkgname%-git}.png"
+    install -Dm644 "$(_get_project_dir)/${pkgname%-git}.desktop" -t "${pkgdir}/usr/share/applications"
+    install -Dm644 "$(_get_project_dir)/LICENSE" -t "${pkgdir}/usr/share/licenses/${pkgname}"
 }
+

Scan history

Scanned at (UTC)	Severity	Rules
2026-11-01 00:21:48	Low	2
2026-10-31 00:07:41	Low	2
2026-10-30 00:29:30	Low	2
2026-10-29 07:52:02	Medium	1
2026-10-29 00:13:55	Low	2
2026-10-28 00:06:54	Low	2
2026-10-27 00:23:28	Low	2
2026-10-26 00:12:40	Low	2
2026-10-25 00:20:48	Low	2
2026-10-24 00:14:55	Low	2
2026-10-23 00:02:19	Low	2
2026-10-22 00:13:10	Low	2
2026-10-21 00:12:50	Low	2
2026-10-20 00:10:31	Low	2
2026-10-19 00:03:55	Low	2
2026-10-18 00:06:55	Low	2
2026-10-17 00:21:55	Low	2
2026-10-16 00:12:47	Low	2
2026-10-15 00:28:05	Low	2
2026-10-14 00:06:47	Low	2