notesnook-git

MEDIUM

maintainer zxp19821005 0 votes scanned 2026-11-01 00:21:48.120785

View on AUR

Why flagged

The PKGBUILD runs 'npm install' on external packages including 'sqlite-better-trigram' which is not declared in the source project's package.json, posing a supply-chain risk from an unverified remote package.

Triggered rules

Medium npm/yarn/pnpm install of an undeclared external package npm_install_external

Runs `npm/yarn/pnpm install <package>` for a package not in source=(), pulling unpinned, unreviewed code at build time. Severity downgraded: the package declares/looks like a Node.js consumer, where build-time installs are expected.

PKGBUILD:106 npm install sqlite-better-trigram

Medium AI review llm_review

An AI model (qwen/qwen3-235b-a22b-2507) reviewed this and agrees it is MEDIUM (confidence 85%): The PKGBUILD runs 'npm install' on external packages including 'sqlite-better-trigram' which is not declared in the source project's package.json, posing a supply-chain risk from an unverified remote package.

PKGBUILD

1 offending line(s) highlighted

      1# Maintainer: zxp19821005 <zxp19821005 at 163 dot com>
    
      2# Contributer: candroid_man <candroid_man@protonmail.com>
    
      3# Contributer: Ada <adadonderr@gmail.com>
    
      4# Contributor: Christian Finnberg <christian@finnberg.net>
    
      5export GIT_LFS_SKIP_SMUDGE=1
    
      6pkgname=notesnook-git
    
      7_pkgname=Notesnook
    
      8pkgver=3.4.11.r6.g488e649
    
      9_electronversion=37
    
      10_nodeversion=22
    
      11pkgrel=1
    
      12pkgdesc="A fully open source & end-to-end encrypted note taking alternative to Evernote."
    
      13arch=(
    
      14    'aarch64'
    
      15    'x86_64'
    
      16)
    
      17url="https://notesnook.com/"
    
      18_ghurl="https://github.com/streetwriters/notesnook"
    
      19license=('GPL-3.0-or-later')
    
      20provides=("${pkgname%-git}=${pkgver%.r*}")
    
      21conflicts=("${pkgname%-git}")
    
      22depends=(
    
      23    "electron${_electronversion}"
    
      24)
    
      25makedepends=(
    
      26    'nvm'
    
      27    'npm'
    
      28    'git'
    
      29    'yarn'
    
      30    'python-setuptools'
    
      31    'jq'
    
      32)
    
      33source=(
    
      34    "${pkgname//-/.}::git+${_ghurl}.git"
    
      35    "${pkgname%-git}.desktop"
    
      36    "${pkgname%-git}.js"
    
      37    "${pkgname%-git}.sh"
    
      38)
    
      39options=('!lto')
    
      40sha256sums=('SKIP'
    
      41            'efc8a6cea79ed0203dcbadf17632b5341952a49704f99e3ea0ddc573b06748f4'
    
      42            '562897be8a17076176f8d985c0d7bc1c685f2e7c9b3a932339ce015963243627'
    
      43            '0f4675ddc96a032accf82723c7b6b66007bafd18aa8d919b61e983a68fd25328')
    
      44_get_project_dir() {
    
      45	local d
    
      46	while IFS= read -r d; do
    
      47		find "$d" -name "package.json" ! -path "*/node_modules/*" 2>/dev/null | grep -q . && { echo "$d"; return; }
    
      48	done < <(find "${srcdir}" -maxdepth 1 -mindepth 1 -type d ! -name '.*')
    
      49}
    
      50pkgver() {
    
      51	cd "$(_get_project_dir)"
    
      52	set -o pipefail
    
      53	git describe --long --tags --abbrev=7 | sed 's/\([^-]*-g\)/r\1/;s/-/./g;s/v//g' ||
    
      54	printf "r%s.%s" "$(git rev-list --count HEAD)" "$(git rev-parse --short=7 HEAD)"
    
      55}
    
      56_ensure_local_nvm() {
    
      57	local NVM_DIR="${srcdir}/.nvm"
    
      58	source /usr/share/nvm/init-nvm.sh || [[ $? != 1 ]]
    
      59	nvm install "${_nodeversion}"
    
      60	nvm use "${_nodeversion}"
    
      61}
    
      62_get_app_dir() {
    
      63	find "${srcdir}" -type f -name "resources.pak" ! -path "*/node_modules/*" -printf '%h\n' 2>/dev/null \
    
      64		| while read -r d; do [[ -d "${d}/resources" ]] && { echo "$d"; return 0; }; done
    
      65}
    
      66_get_electron_version() {
    
      67	_elec_ver=$(find "$(_get_project_dir)" -name "package.json" ! -path "*/node_modules/*" -print \
    
      68		| xargs -I{} jq -r '(.devDependencies.electron // .dependencies.electron) // empty' {} 2>/dev/null \
    
      69		| grep -oE '[0-9]+' | head -1)
    
      70	[[ -z "${_elec_ver}" ]] && return 1
    
      71	(( _elec_ver == _electronversion )) && c=32 || c=31
    
      72	echo -e "Electron version: \033[1;${c}m${_elec_ver}$([[ $c -eq 31 ]] && echo " (expected ${_electronversion})")\033[0m"
    
      73}
    
      74_set_build_env() {
    
      75	export ELECTRON_DIST="/usr/lib/electron${_electronversion}"
    
      76	export ELECTRON_OVERRIDE_DIST_PATH="${ELECTRON_DIST}"
    
      77	export ELECTRON_SKIP_BINARY_DOWNLOAD=1
    
      78	export ELECTRON_BUILDER_OFFLINE=true
    
      79	export SYSTEM_ELECTRON_VERSION="$(electron${_electronversion} -v | sed 's/^v//')"
    
      80	export HOME="${srcdir}/.home"
    
      81	export XDG_CACHE_HOME="${HOME}/.cache"
    
      82	export XDG_CONFIG_HOME="${HOME}/.config"
    
      83	export XDG_DATA_HOME="${HOME}/.local/share"
    
      84	export npm_config_cache="${HOME}/.npm_cache"
    
      85	export COREPACK_NPM_REGISTRY="${COREPACK_NPM_REGISTRY:-${NPM_CONFIG_REGISTRY:-https://registry.npmjs.org}}"
    
      86	export COREPACK_HOME="${HOME}/.corepack"
    
      87	export npm_config_audit=false
    
      88	export npm_config_registry="${NPM_CONFIG_REGISTRY:-${npm_config_registry:-https://registry.npmjs.org}}"
    
      89	mkdir -p "${HOME}" "${npm_config_cache}" "${COREPACK_HOME}"
    
      90}
    
      91prepare() {
    
      92    export GIT_LFS_SKIP_SMUDGE=1
    
      93    cd "$(_get_project_dir)"
    
      94    _get_electron_version
    
      95    sed -i -e "
    
      96        s/@electronversion@/${_electronversion}/g
    
      97        s/@appname@/${pkgname%-git}/g
    
      98    " "${srcdir}/${pkgname%-git}.sh" "${srcdir}/${pkgname%-git}.js"
    
      99    _ensure_local_nvm
    
      100    _set_build_env
    
      101    sed -i "s/npm \${/NODE_ENV=development npm \${/g" scripts/bootstrap.mjs
    
      102    export NODE_ENV=development
    
      103    npm install --ignore-scripts --prefer-offline --no-audit
    
      104    npm run bootstrap -- --scope=web
    
      105    npm run bootstrap -- --scope=desktop
    
      106    npm install sqlite-better-trigram
    
      107}
    
      108build() {
    
      109    cd "$(_get_project_dir)"
    
      110    _ensure_local_nvm
    
      111    _set_build_env
    
      112    export NODE_ENV=production
    
      113    npm run tx @notesnook/web:build:desktop
    
      114    cd apps/desktop
    
      115    jq --arg ver "${SYSTEM_ELECTRON_VERSION}" '.devDependencies.electron = $ver' package.json > package.json.tmp && mv package.json.tmp package.json
    
      116    npm run bundle
    
      117    cp -r "$(_get_project_dir)/apps/web/build" "$(_get_project_dir)/apps/desktop"
    
      118    npm exec -c "electron-builder --linux dir -c.electronDist=${ELECTRON_DIST} --config=electron-builder.config.js"
    
      119    rm -rf "$(_get_app_dir)/resources/default_app.asar"
    
      120}
    
      121package() {
    
      122    install -Dm755 "${srcdir}/${pkgname%-git}.sh" "${pkgdir}/usr/bin/${pkgname%-git}"
    
      123    install -Dm644 "${srcdir}/${pkgname%-git}.js" -t "${pkgdir}/usr/lib/${pkgname%-git}"
    
      124	cp -a "$(_get_app_dir)/resources/." "${pkgdir}/usr/lib/${pkgname%-git}/"
    
      125    _icon_sizes=(16x16 24x24 32x32 48x48 64x64 128x128 256x256 512x512 1024x1024)
    
      126    for _icons in "${_icon_sizes[@]}";do
    
      127        install -Dm644 "$(_get_project_dir)/apps/desktop/assets/icons/${_icons}.png" \
    
      128            "${pkgdir}/usr/share/icons/hicolor/${_icons}/apps/${pkgname%-git}.png"
    
      129    done
    
      130    install -Dm644 "${srcdir}/${pkgname%-git}.desktop" -t "${pkgdir}/usr/share/applications"
    
      131}
    
      132

Changes since previous scan

--- PKGBUILD @ 2026-10-26 00:12
+++ PKGBUILD @ 2026-11-01 00:21
@@ -2,9 +2,10 @@
 # Contributer: candroid_man <candroid_man@protonmail.com>
 # Contributer: Ada <adadonderr@gmail.com>
 # Contributor: Christian Finnberg <christian@finnberg.net>
+export GIT_LFS_SKIP_SMUDGE=1
 pkgname=notesnook-git
 _pkgname=Notesnook
-pkgver=3.4.9.r31.gadd8f57
+pkgver=3.4.11.r6.g488e649
 _electronversion=37
 _nodeversion=22
 pkgrel=1
@@ -25,7 +26,6 @@
     'nvm'
     'npm'
     'git'
-    'zip'
     'yarn'
     'python-setuptools'
     'jq'
@@ -33,31 +33,43 @@
 source=(
     "${pkgname//-/.}::git+${_ghurl}.git"
     "${pkgname%-git}.desktop"
+    "${pkgname%-git}.js"
     "${pkgname%-git}.sh"
 )
+options=('!lto')
 sha256sums=('SKIP'
             'efc8a6cea79ed0203dcbadf17632b5341952a49704f99e3ea0ddc573b06748f4'
-            'bd5358d8f323d3c2c2f0733364ee4ea55f551dd86ba0be2a76846210b60897fc')
-pkgver() {
-    cd "$(_get_project_dir)"
-    set -o pipefail
-    git describe --long --tags --abbrev=7 | sed 's/\([^-]*-g\)/r\1/;s/-/./g;s/v//g;s/\.android//g' ||
-    printf "r%s.%s" "$(git rev-list --count HEAD)" "$(git rev-parse --short=7 HEAD)"
-}
+            '562897be8a17076176f8d985c0d7bc1c685f2e7c9b3a932339ce015963243627'
+            '0f4675ddc96a032accf82723c7b6b66007bafd18aa8d919b61e983a68fd25328')
 _get_project_dir() {
 	local d
 	while IFS= read -r d; do
 		find "$d" -name "package.json" ! -path "*/node_modules/*" 2>/dev/null | grep -q . && { echo "$d"; return; }
 	done < <(find "${srcdir}" -maxdepth 1 -mindepth 1 -type d ! -name '.*')
 }
-_get_app_dir() {
-	find "${srcdir}" -type f -name "resources.pak" -print 2>/dev/null | while read f; do [ -d "${f%/*}/resources" ] && echo "${f%/*}" && break; done
+pkgver() {
+	cd "$(_get_project_dir)"
+	set -o pipefail
+	git describe --long --tags --abbrev=7 | sed 's/\([^-]*-g\)/r\1/;s/-/./g;s/v//g' ||
+	printf "r%s.%s" "$(git rev-list --count HEAD)" "$(git rev-parse --short=7 HEAD)"
 }
 _ensure_local_nvm() {
-    local NVM_DIR="${srcdir}/.nvm"
-    source /usr/share/nvm/init-nvm.sh || [[ $? != 1 ]]
-    nvm install "${_nodeversion}"
-    nvm use "${_nodeversion}"
+	local NVM_DIR="${srcdir}/.nvm"
+	source /usr/share/nvm/init-nvm.sh || [[ $? != 1 ]]
+	nvm install "${_nodeversion}"
+	nvm use "${_nodeversion}"
+}
+_get_app_dir() {
+	find "${srcdir}" -type f -name "resources.pak" ! -path "*/node_modules/*" -printf '%h\n' 2>/dev/null \
+		| while read -r d; do [[ -d "${d}/resources" ]] && { echo "$d"; return 0; }; done
+}
+_get_electron_version() {
+	_elec_ver=$(find "$(_get_project_dir)" -name "package.json" ! -path "*/node_modules/*" -print \
+		| xargs -I{} jq -r '(.devDependencies.electron // .dependencies.electron) // empty' {} 2>/dev/null \
+		| grep -oE '[0-9]+' | head -1)
+	[[ -z "${_elec_ver}" ]] && return 1
+	(( _elec_ver == _electronversion )) && c=32 || c=31
+	echo -e "Electron version: \033[1;${c}m${_elec_ver}$([[ $c -eq 31 ]] && echo " (expected ${_electronversion})")\033[0m"
 }
 _set_build_env() {
 	export ELECTRON_DIST="/usr/lib/electron${_electronversion}"
@@ -76,22 +88,14 @@
 	export npm_config_registry="${NPM_CONFIG_REGISTRY:-${npm_config_registry:-https://registry.npmjs.org}}"
 	mkdir -p "${HOME}" "${npm_config_cache}" "${COREPACK_HOME}"
 }
-_get_electron_version() {
-	_elec_ver=$(find "$(_get_project_dir)" -name "package.json" ! -path "*/node_modules/*" -print \
-		| xargs -I{} jq -r '(.devDependencies.electron // .dependencies.electron) // empty' {} 2>/dev/null \
-		| grep -v '^$' | sed 's/^[^0-9]*//' | head -1)
-	[[ -z "${_elec_ver}" ]] && return 1
-	echo -e "The electron version is: \033[1;31m${_elec_ver%%.*}\033[0m"
-}
 prepare() {
+    export GIT_LFS_SKIP_SMUDGE=1
     cd "$(_get_project_dir)"
     _get_electron_version
     sed -i -e "
         s/@electronversion@/${_electronversion}/g
         s/@appname@/${pkgname%-git}/g
-        s/@runname@/app.asar/g
-        s/@cfgdirname@/${_pkgname}/g
-    " "${srcdir}/${pkgname%-git}.sh"
+    " "${srcdir}/${pkgname%-git}.sh" "${srcdir}/${pkgname%-git}.js"
     _ensure_local_nvm
     _set_build_env
     sed -i "s/npm \${/NODE_ENV=development npm \${/g" scripts/bootstrap.mjs
@@ -105,24 +109,22 @@
     cd "$(_get_project_dir)"
     _ensure_local_nvm
     _set_build_env
-    local _src="$(_get_project_dir)"
     export NODE_ENV=production
     npm run tx @notesnook/web:build:desktop
     cd apps/desktop
     jq --arg ver "${SYSTEM_ELECTRON_VERSION}" '.devDependencies.electron = $ver' package.json > package.json.tmp && mv package.json.tmp package.json
     npm run bundle
-    cp -r "${_src}/apps/web/build" "${_src}/apps/desktop"
+    cp -r "$(_get_project_dir)/apps/web/build" "$(_get_project_dir)/apps/desktop"
     npm exec -c "electron-builder --linux dir -c.electronDist=${ELECTRON_DIST} --config=electron-builder.config.js"
+    rm -rf "$(_get_app_dir)/resources/default_app.asar"
 }
 package() {
     install -Dm755 "${srcdir}/${pkgname%-git}.sh" "${pkgdir}/usr/bin/${pkgname%-git}"
-    install -Dm755 -d "${pkgdir}/usr/lib/${pkgname%-git}"
-	local _app_dir="$(_get_app_dir)"
-	cp -a "${_app_dir}/resources/." "${pkgdir}/usr/lib/${pkgname%-git}/"
-    local _src="$(_get_project_dir)"
+    install -Dm644 "${srcdir}/${pkgname%-git}.js" -t "${pkgdir}/usr/lib/${pkgname%-git}"
+	cp -a "$(_get_app_dir)/resources/." "${pkgdir}/usr/lib/${pkgname%-git}/"
     _icon_sizes=(16x16 24x24 32x32 48x48 64x64 128x128 256x256 512x512 1024x1024)
     for _icons in "${_icon_sizes[@]}";do
-        install -Dm644 "${_src}/apps/desktop/assets/icons/${_icons}.png" \
+        install -Dm644 "$(_get_project_dir)/apps/desktop/assets/icons/${_icons}.png" \
             "${pkgdir}/usr/share/icons/hicolor/${_icons}/apps/${pkgname%-git}.png"
     done
     install -Dm644 "${srcdir}/${pkgname%-git}.desktop" -t "${pkgdir}/usr/share/applications"

Scan history

Scanned at (UTC)	Severity	Rules
2026-11-01 00:21:48	Medium	2
2026-10-31 00:07:41	Medium	2
2026-10-30 00:29:30	Medium	2
2026-10-29 00:13:55	Medium	2
2026-10-28 00:06:54	Medium	2
2026-10-27 00:23:28	Medium	2
2026-10-26 23:46:04	Medium	2
2026-10-26 00:12:40	Low	2
2026-10-25 00:20:48	Low	2
2026-10-24 00:14:55	Low	2
2026-10-23 00:02:19	Low	2
2026-10-22 11:34:35	Medium	1
2026-10-22 00:13:10	Low	2
2026-10-21 00:12:50	Low	2
2026-10-20 00:10:31	Low	2
2026-10-19 00:03:55	Low	2
2026-10-18 00:06:55	Low	2
2026-10-17 00:21:55	Low	2
2026-10-16 00:12:47	Low	2
2026-10-15 00:28:05	Low	2