notesnook-git

maintainer zxp19821005 · 0 votes · scanned 2026-08-03 00:08:14.047287

LOW

Why flagged The flagged npm install of 'sqlite-better-trigram' occurs during prepare() but is a legitimate dependency needed for building the application; the package builds from source using the project's own git repository, and no untrusted prebuilt binaries are used.

Triggered rules

LOW AI review downgraded a static finding llm_review

The static rules flagged this MEDIUM, but an AI model (qwen/qwen3-235b-a22b-2507) reviewed the full PKGBUILD and judged it LOW (confidence 90%): The flagged npm install of 'sqlite-better-trigram' occurs during prepare() but is a legitimate dependency needed for building the application; the package builds from source using the project's own git repository, and no untrusted prebuilt binaries are used.

1 higher static finding superseded - not the current verdict (shown for transparency)

MEDIUM npm/yarn/pnpm install of an undeclared external package npm_install_external

Runs `npm/yarn/pnpm install <package>` for a package not in source=(), pulling unpinned, unreviewed code at build time. Severity downgraded: the package declares/looks like a Node.js consumer, where build-time installs are expected.

PKGBUILD:95 NODE_ENV=development npm install sqlite-better-trigram

PKGBUILD

1 offending line(s) highlighted

      1# Maintainer: zxp19821005 <zxp19821005 at 163 dot com>
    
      2# Contributer: candroid_man <candroid_man@protonmail.com>
    
      3# Contributer: Ada <adadonderr@gmail.com>
    
      4# Contributor: Christian Finnberg <christian@finnberg.net>
    
      5pkgname=notesnook-git
    
      6_pkgname=Notesnook
    
      7pkgver=3.4.5.r0.gb5140d9
    
      8_electronversion=37
    
      9_nodeversion=22
    
      10pkgrel=1
    
      11pkgdesc="A fully open source & end-to-end encrypted note taking alternative to Evernote.(Use system-wide electron)"
    
      12arch=(
    
      13    'aarch64'
    
      14    'x86_64'
    
      15)
    
      16url="https://notesnook.com/"
    
      17_ghurl="https://github.com/streetwriters/notesnook"
    
      18license=('GPL-3.0-or-later')
    
      19provides=("${pkgname%-git}=${pkgver%.r*}")
    
      20conflicts=("${pkgname%-git}")
    
      21depends=(
    
      22    "electron${_electronversion}"
    
      23)
    
      24makedepends=(
    
      25    'nvm'
    
      26    'npm'
    
      27    'git'
    
      28    'zip'
    
      29    'curl'
    
      30    'yarn'
    
      31    'python-setuptools'
    
      32    'jq'
    
      33)
    
      34source=(
    
      35    "${pkgname//-/.}::git+${_ghurl}.git"
    
      36    "${pkgname%-git}.desktop"
    
      37    "${pkgname%-git}.sh"
    
      38)
    
      39sha256sums=('SKIP'
    
      40            'efc8a6cea79ed0203dcbadf17632b5341952a49704f99e3ea0ddc573b06748f4'
    
      41            'a774c2f54fbbeeaac3cefc0f7250796d30c86d27f0fd40b7eaf9c0fdb021623d')
    
      42pkgver() {
    
      43    cd "${srcdir}/${pkgname//-/.}"
    
      44    set -o pipefail
    
      45    git describe --long --tags --abbrev=7 | sed 's/\([^-]*-g\)/r\1/;s/-/./g;s/v//g;s/\.android//g' ||
    
      46    printf "r%s.%s" "$(git rev-list --count HEAD)" "$(git rev-parse --short=7 HEAD)"
    
      47}
    
      48_get_app_dir() {
    
      49    find "${srcdir}" -type f -name "resources.pak" -exec dirname {} + | head -n 1
    
      50}
    
      51_ensure_local_nvm() {
    
      52    local NVM_DIR="${srcdir}/.nvm"
    
      53    source /usr/share/nvm/init-nvm.sh || [[ $? != 1 ]]
    
      54    nvm install "${_nodeversion}"
    
      55    nvm use "${_nodeversion}"
    
      56}
    
      57_set_build_env() {
    
      58    export ELECTRON_DIST="/usr/lib/electron${_electronversion}"
    
      59    export ELECTRON_SKIP_BINARY_DOWNLOAD=1
    
      60    export SYSTEM_ELECTRON_VERSION="$(electron${_electronversion} -v | sed 's/v//g')"
    
      61    export HOME="${srcdir}/.electron-gyp"
    
      62    export NPM_CONFIG_CACHE="${srcdir}/.npm_cache"
    
      63    export NPM_CONFIG_MAXSOCKETS=32
    
      64    if [[ "$(curl -s ipinfo.io/country)" == *"CN"* ]]; then
    
      65        {
    
      66            export NPM_CONFIG_REGISTRY="https://registry.npmmirror.com"
    
      67            export NODEJS_ORG_MIRROR="https://npmmirror.com/mirrors/node"
    
      68            export ELECTRON_MIRROR="https://npmmirror.com/mirrors/electron/"
    
      69            export ELECTRON_BUILDER_BINARIES_MIRROR="https://npmmirror.com/mirrors/electron-builder-binaries/"
    
      70        }
    
      71        find ./ -type f -name "package-lock.json" -exec sed -i "s/registry.npmjs.org/registry.npmmirror.com/g" {} +
    
      72    fi
    
      73}
    
      74_get_electron_version() {
    
      75    _elec_ver=$(jq -r '.devDependencies["electron"] // .dependencies["electron"]' "${srcdir}/${pkgname//-/.}/apps/desktop/package.json" | tr -d '^')
    
      76    _main_ver=$(echo "${_elec_ver}" | cut -d. -f1)
    
      77    echo -e "The electron version is: \033[1;31m${_main_ver}\033[0m"
    
      78}
    
      79prepare() {
    
      80    cd "${srcdir}/${pkgname//-/.}"
    
      81    _get_electron_version
    
      82    sed -i -e "
    
      83        s/@electronversion@/${_electronversion}/g
    
      84        s/@appname@/${pkgname%-git}/g
    
      85        s/@runname@/app.asar/g
    
      86        s/@cfgdirname@/${_pkgname}/g
    
      87    " "${srcdir}/${pkgname%-git}.sh"
    
      88    _set_build_env
    
      89    _ensure_local_nvm
    
      90    cd "${srcdir}/${pkgname//-/.}"
    
      91    sed -i "s/npm \${/NODE_ENV=development npm \${/g" scripts/bootstrap.mjs
    
      92    NODE_ENV=development    npm install --ignore-scripts --prefer-offline --no-audit
    
      93    NODE_ENV=development    npm run bootstrap -- --scope=web
    
      94    NODE_ENV=development    npm run bootstrap -- --scope=desktop
    
      95    NODE_ENV=development    npm install sqlite-better-trigram
    
      96}
    
      97build() {
    
      98    cd "${srcdir}/${pkgname//-/.}"
    
      99    _set_build_env
    
      100    _ensure_local_nvm
    
      101    NODE_ENV=production     npm run tx @notesnook/web:build:desktop
    
      102    cd "${srcdir}/${pkgname//-/.}/apps/desktop"
    
      103    local electronDist="/usr/lib/electron${_electronversion}"
    
      104    sed -i "s/\"electron\": \"[^\"]*\"/\"electron\": \"${SYSTEM_ELECTRON_VERSION}\"/g" package.json
    
      105    NODE_ENV=production     npm run bundle
    
      106    cp -r "${srcdir}/${pkgname//-/.}/apps/web/build" "${srcdir}/${pkgname//-/.}/apps/desktop"
    
      107    NODE_ENV=production     npm exec -c "electron-builder --linux dir -c.electronDist=${ELECTRON_DIST} --config=electron-builder.config.js"
    
      108}
    
      109package() {
    
      110    install -Dm755 "${srcdir}/${pkgname%-git}.sh" "${pkgdir}/usr/bin/${pkgname%-git}"
    
      111    install -Dm755 -d "${pkgdir}/usr/lib/${pkgname%-git}"
    
      112	local _app_dir=$(_get_app_dir)
    
      113	cp -a "${_app_dir}/resources/"* "${pkgdir}/usr/lib/${pkgname%-git}/"
    
      114    _icon_sizes=(16x16 24x24 32x32 48x48 64x64 128x128 256x256 512x512 1024x1024)
    
      115    for _icons in "${_icon_sizes[@]}";do
    
      116        install -Dm644 "${srcdir}/${pkgname//-/.}/apps/desktop/assets/icons/${_icons}.png" \
    
      117            "${pkgdir}/usr/share/icons/hicolor/${_icons}/apps/${pkgname%-git}.png"
    
      118    done
    
      119    install -Dm644 "${srcdir}/${pkgname%-git}.desktop" -t "${pkgdir}/usr/share/applications"
    
      120}
    
      121

Changes since previous scan

--- PKGBUILD @ 2026-07-29 00:25
+++ PKGBUILD @ 2026-08-03 00:08
@@ -4,7 +4,7 @@
 # Contributor: Christian Finnberg <christian@finnberg.net>
 pkgname=notesnook-git
 _pkgname=Notesnook
-pkgver=3.4.1.r0.gb2ed115
+pkgver=3.4.5.r0.gb5140d9
 _electronversion=37
 _nodeversion=22
 pkgrel=1
@@ -55,7 +55,7 @@
     nvm use "${_nodeversion}"
 }
 _set_build_env() {
-    export electronDist="/usr/lib/electron${_electronversion}"
+    export ELECTRON_DIST="/usr/lib/electron${_electronversion}"
     export ELECTRON_SKIP_BINARY_DOWNLOAD=1
     export SYSTEM_ELECTRON_VERSION="$(electron${_electronversion} -v | sed 's/v//g')"
     export HOME="${srcdir}/.electron-gyp"
@@ -64,8 +64,6 @@
     if [[ "$(curl -s ipinfo.io/country)" == *"CN"* ]]; then
         {
             export NPM_CONFIG_REGISTRY="https://registry.npmmirror.com"
-            export NPM_CONFIG_ELECTRON_MIRROR="https://registry.npmmirror.com/-/binary/electron/"
-            export NPM_CONFIG_ELECTRON_BUILDER_BINARIES_MIRROR="https://registry.npmmirror.com/-/binary/electron-builder-binaries/"
             export NODEJS_ORG_MIRROR="https://npmmirror.com/mirrors/node"
             export ELECTRON_MIRROR="https://npmmirror.com/mirrors/electron/"
             export ELECTRON_BUILDER_BINARIES_MIRROR="https://npmmirror.com/mirrors/electron-builder-binaries/"
@@ -106,13 +104,13 @@
     sed -i "s/\"electron\": \"[^\"]*\"/\"electron\": \"${SYSTEM_ELECTRON_VERSION}\"/g" package.json
     NODE_ENV=production     npm run bundle
     cp -r "${srcdir}/${pkgname//-/.}/apps/web/build" "${srcdir}/${pkgname//-/.}/apps/desktop"
-    NODE_ENV=production     npm exec -c "electron-builder --linux dir -c.electronDist=${electronDist} --config=electron-builder.config.js"
+    NODE_ENV=production     npm exec -c "electron-builder --linux dir -c.electronDist=${ELECTRON_DIST} --config=electron-builder.config.js"
 }
 package() {
     install -Dm755 "${srcdir}/${pkgname%-git}.sh" "${pkgdir}/usr/bin/${pkgname%-git}"
     install -Dm755 -d "${pkgdir}/usr/lib/${pkgname%-git}"
 	local _app_dir=$(_get_app_dir)
-	cp -a "${_app_dir}/resources/". "${pkgdir}/usr/lib/${pkgname%-git}/"
+	cp -a "${_app_dir}/resources/"* "${pkgdir}/usr/lib/${pkgname%-git}/"
     _icon_sizes=(16x16 24x24 32x32 48x48 64x64 128x128 256x256 512x512 1024x1024)
     for _icons in "${_icon_sizes[@]}";do
         install -Dm644 "${srcdir}/${pkgname//-/.}/apps/desktop/assets/icons/${_icons}.png" \

Scan history

Scanned at (UTC)	Severity	Rules
2026-08-03 00:08:14	LOW	2
2026-08-02 00:16:08	LOW	2
2026-08-01 00:11:18	LOW	2
2026-07-31 00:14:10	LOW	2
2026-07-30 00:17:23	LOW	2
2026-07-29 01:40:32	MEDIUM	1
2026-07-29 00:25:53	LOW	2
2026-07-28 00:07:28	LOW	2
2026-07-27 00:24:32	LOW	2
2026-07-26 00:07:32	LOW	2
2026-07-25 00:13:44	LOW	2
2026-07-24 00:02:28	LOW	2
2026-07-23 00:14:47	LOW	2
2026-07-22 00:29:32	LOW	2
2026-07-21 00:24:15	LOW	2
2026-07-20 00:19:49	LOW	2
2026-07-19 00:17:08	LOW	2
2026-07-18 00:14:48	LOW	2
2026-07-17 00:06:16	LOW	2
2026-07-16 00:05:41	LOW	2