pip-player-git

LOW

maintainer zxp19821005 0 votes scanned 2026-11-01 00:21:48.120785

View on AUR

Why flagged

The npx commands are used to run build scripts (clean.js, electron-builder) from the project's own source tree during packaging, not to execute arbitrary remote code.

Triggered rules

Low AI review downgraded a static finding llm_review

The static rules flagged this MEDIUM, but an AI model (qwen/qwen3-235b-a22b-2507) reviewed the full PKGBUILD and judged it LOW (confidence 95%): The npx commands are used to run build scripts (clean.js, electron-builder) from the project's own source tree during packaging, not to execute arbitrary remote code.

1 higher static finding superseded - not the current verdict (shown for transparency)

Medium npx/bunx/deno executes a remote package remote_code_tool

`npx`/`bunx`/`pnpm dlx`/`deno run <url>` downloads AND runs a remote package at build time — the moral equivalent of piping a download into a shell. Severity downgraded: Node.js consumer context.

PKGBUILD:103 npx ts-node ./.erb/scripts/clean.js dist
PKGBUILD:106 npx electron-builder --linux dir -c.electronDist="${ELECTRON_DIST}"

PKGBUILD

2 offending line(s) highlighted

      1# Maintainer: zxp19821005 <zxp19821005 at 163 dot com>
    
      2pkgname=pip-player-git
    
      3_pkgname='PiP Player'
    
      4pkgver=1.2.4.r0.gd6e674e
    
      5_electronversion=31
    
      6_nodeversion=20
    
      7pkgrel=1
    
      8pkgdesc="A simple application to play PiP(Picture-in-Picture) with any links that you like."
    
      9arch=('any')
    
      10url="https://github.com/WickyPlays/pip-player"
    
      11license=('MIT')
    
      12conflicts=("${pkgname%-git}")
    
      13provides=("${pkgname%-git}=${pkgver%.r*}")
    
      14depends=(
    
      15    "electron${_electronversion}"
    
      16)
    
      17makedepends=(
    
      18    'gendesk'
    
      19    'npm'
    
      20    'nvm'
    
      21    'git'
    
      22    'jq'
    
      23)
    
      24source=(
    
      25    "${pkgname%-git}.git::git+${url}"
    
      26    "${pkgname%-git}.sh"
    
      27)
    
      28sha256sums=('SKIP'
    
      29            'bd5358d8f323d3c2c2f0733364ee4ea55f551dd86ba0be2a76846210b60897fc')
    
      30_get_project_dir() {
    
      31	local d
    
      32	while IFS= read -r d; do
    
      33		find "$d" -name "package.json" ! -path "*/node_modules/*" 2>/dev/null | grep -q . && { echo "$d"; return; }
    
      34	done < <(find "${srcdir}" -maxdepth 1 -mindepth 1 -type d ! -name '.*')
    
      35}
    
      36pkgver() {
    
      37    cd "$(_get_project_dir)"
    
      38    set -o pipefail
    
      39    git describe --long --tags --abbrev=7 | sed 's/\([^-]*-g\)/r\1/;s/-/./g;s/v//;s/release.//' ||
    
      40    printf "r%s.%s" "$(git rev-list --count HEAD)" "$(git rev-parse --short=7 HEAD)"
    
      41}
    
      42_ensure_local_nvm() {
    
      43    local NVM_DIR="${srcdir}/.nvm"
    
      44    source /usr/share/nvm/init-nvm.sh || [[ $? != 1 ]]
    
      45    nvm install "${_nodeversion}"
    
      46    nvm use "${_nodeversion}"
    
      47}
    
      48_get_app_dir() {
    
      49	find "$(_get_project_dir)" -type d -name "node_modules" -prune -o -type f -name "resources.pak" -print0 | xargs -0 dirname | head -n 1
    
      50}
    
      51_get_electron_version() {
    
      52	_elec_ver=$(find "$(_get_project_dir)" -name "package.json" ! -path "*/node_modules/*" -print \
    
      53		| xargs -I{} jq -r '(.devDependencies.electron // .dependencies.electron) // empty' {} 2>/dev/null \
    
      54		| grep -v '^$' | sed 's/^[^0-9]*//' | head -1)
    
      55	[[ -z "${_elec_ver}" ]] && return 1
    
      56	echo -e "The electron version is: \033[1;31m${_elec_ver%%.*}\033[0m"
    
      57}
    
      58_set_build_env() {
    
      59	export ELECTRON_DIST="/usr/lib/electron${_electronversion}"
    
      60	export ELECTRON_OVERRIDE_DIST_PATH="${ELECTRON_DIST}"
    
      61	export ELECTRON_SKIP_BINARY_DOWNLOAD=1
    
      62	export ELECTRON_BUILDER_OFFLINE=true
    
      63	export SYSTEM_ELECTRON_VERSION="$(electron${_electronversion} -v | sed 's/^v//')"
    
      64	export HOME="${srcdir}/.home"
    
      65	export XDG_CACHE_HOME="${HOME}/.cache"
    
      66	export XDG_CONFIG_HOME="${HOME}/.config"
    
      67	export XDG_DATA_HOME="${HOME}/.local/share"
    
      68	export npm_config_cache="${HOME}/.npm_cache"
    
      69	export COREPACK_NPM_REGISTRY="${COREPACK_NPM_REGISTRY:-${NPM_CONFIG_REGISTRY:-https://registry.npmjs.org}}"
    
      70	export COREPACK_HOME="${HOME}/.corepack"
    
      71	export npm_config_audit=false
    
      72	mkdir -p "${HOME}" "${npm_config_cache}" "${COREPACK_HOME}"
    
      73}
    
      74prepare() {
    
      75    cd "$(_get_project_dir)"
    
      76    _get_electron_version
    
      77    sed -i -e "
    
      78        s/@electronversion@/${_electronversion}/g
    
      79        s/@appname@/${pkgname%-git}/g
    
      80        s/@runname@/app.asar/g
    
      81        s/@cfgdirname@/${pkgname%-git}/g
    
      82    " "${srcdir}/${pkgname%-git}.sh"
    
      83    gendesk -q -f -n \
    
      84        --pkgname="${pkgname%-git}" \
    
      85        --pkgdesc="${pkgdesc}" \
    
      86        --categories="Utility" \
    
      87        --name="${pkgname%-git}" \
    
      88        --exec="${pkgname%-git} %U"
    
      89    _ensure_local_nvm
    
      90    _set_build_env
    
      91    find src -type f -exec sed -i "s/process.resourcesPath/\'\/usr\/lib\/${pkgname%-git}\'/g" {} \;
    
      92    touch src/renderer/style.css
    
      93    sed -i "s/\"electron\": \"[^\"]*\"/\"electron\": \"${SYSTEM_ELECTRON_VERSION}\"/g" package.json
    
      94    export NODE_ENV=development
    
      95    npm install --legacy-peer-deps
    
      96}
    
      97build() {
    
      98    cd "$(_get_project_dir)"
    
      99    _ensure_local_nvm
    
      100    _set_build_env
    
      101    export NODE_ENV=production
    
      102    npm run build:dll
    
      103    npx ts-node ./.erb/scripts/clean.js dist
    
      104    npm run build:main
    
      105    npm run build:renderer
    
      106    npx electron-builder --linux dir -c.electronDist="${ELECTRON_DIST}"
    
      107}
    
      108package() {
    
      109    install -Dm755 "${srcdir}/${pkgname%-git}.sh" "${pkgdir}/usr/bin/${pkgname%-git}"
    
      110    install -Dm755 -d "${pkgdir}/usr/lib/${pkgname%-git}"
    
      111	local _app_dir=$(_get_app_dir)
    
      112    local _src="$(_get_project_dir)"
    
      113	cp -a "${_app_dir}/resources/." "${pkgdir}/usr/lib/${pkgname%-git}/"
    
      114    install -Dm644 "${_src}/${pkgname%-git}.desktop" -t "${pkgdir}/usr/share/applications"
    
      115    install -Dm644 "${_src}/assets/icon.png" "${pkgdir}/usr/share/pixmaps/${pkgname%-git}.png"
    
      116    install -Dm644 "${_src}/LICENSE" -t "${pkgdir}/usr/share/licenses/${pkgname}"
    
      117}

Scan history

Scanned at (UTC)	Severity	Rules
2026-11-01 00:21:48	Low	2
2026-10-31 00:07:41	Low	2
2026-10-30 00:29:30	Low	2
2026-10-29 00:13:55	Low	2
2026-10-28 00:06:54	Low	2
2026-10-27 00:23:28	Low	2
2026-10-26 00:12:40	Low	2
2026-10-25 00:20:48	Low	2
2026-10-24 00:14:55	Low	2
2026-10-23 00:02:19	Low	2
2026-10-22 00:13:10	Low	2
2026-10-21 00:12:50	Low	2
2026-10-20 00:10:31	Low	2
2026-10-19 00:03:55	Low	2
2026-10-18 00:06:55	Low	2
2026-10-17 00:21:55	Low	2
2026-10-16 00:12:47	Low	2
2026-10-15 00:28:05	Low	2
2026-10-14 00:06:47	Low	2
2026-10-13 00:23:45	Low	2