signal-desktop-git

maintainer Bink · 0 votes · scanned 2026-08-03 00:08:14.047287

LOW

Why flagged The pnpm install commands are run on the project's own source from GitHub, which is a legitimate build step for a Node.js application, not an undeclared external package installation.

Triggered rules

LOW AI review downgraded a static finding llm_review

The static rules flagged this MEDIUM, but an AI model (qwen/qwen3-235b-a22b-07-25) reviewed the full PKGBUILD and judged it LOW (confidence 95%): The pnpm install commands are run on the project's own source from GitHub, which is a legitimate build step for a Node.js application, not an undeclared external package installation.

1 higher static finding superseded - not the current verdict (shown for transparency)

MEDIUM npm/yarn/pnpm install of an undeclared external package npm_install_external

Runs `npm/yarn/pnpm install <package>` for a package not in source=(), pulling unpinned, unreviewed code at build time. Severity downgraded: the package declares/looks like a Node.js consumer, where build-time installs are expected.

PKGBUILD:83 pnpm install --dir sticker-creator

PKGBUILD

1 offending line(s) highlighted

      1# Maintainer: Bink
    
      2
    
      3pkgname=signal-desktop-git
    
      4_pkgname=Signal-Desktop
    
      5pkgver=7.89.0.alpha.1.r23.g753766e4de
    
      6pkgrel=1
    
      7pkgdesc="Signal Private Messenger for Linux"
    
      8license=('AGPL-3.0-only')
    
      9arch=('x86_64')
    
      10url="https://signal.org"
    
      11provides=('signal-desktop')
    
      12conflicts=('signal-desktop')
    
      13depends=(
    
      14  'alsa-lib' 'libasound.so'
    
      15  'at-spi2-core' 'libatk-bridge-2.0.so'
    
      16  'cairo' 'libcairo.so'
    
      17  'dbus' 'libdbus-1.so'
    
      18  'expat' 'libexpat.so'
    
      19  'gcc-libs'
    
      20  'glib2' 'libgio-2.0.so'
    
      21  'glibc'
    
      22  'gtk3'
    
      23  'hicolor-icon-theme'
    
      24  'libcups'
    
      25  'libdrm'
    
      26  'libnotify'
    
      27  'libpulse'
    
      28  'libx11'
    
      29  'libxcb'
    
      30  'libxcomposite'
    
      31  'libxdamage'
    
      32  'libxext'
    
      33  'libxfixes'
    
      34  'libxkbcommon' 'libxkbcommon.so'
    
      35  'libxrandr'
    
      36  'mesa'
    
      37  'nspr'
    
      38  'nss'
    
      39  'pango' 'libpango-1.0.so'
    
      40  'systemd-libs' 'libudev.so'
    
      41)
    
      42makedepends=(
    
      43  'git'
    
      44  'git-lfs'
    
      45  'libxcrypt-compat'
    
      46  'node-gyp'
    
      47  'nodejs'
    
      48  'pnpm'
    
      49  'python'
    
      50  'jq'
    
      51)
    
      52optdepends=('xdg-desktop-portal: Screensharing with Wayland')
    
      53source=(
    
      54  "git+https://github.com/signalapp/${_pkgname}.git"
    
      55  "${_pkgname,,}.desktop"
    
      56)
    
      57sha256sums=('SKIP'
    
      58            'bf388df4b5bbcab5559ebbf220ed4748ed21b057f24b5ff46684e3fe6e88ccce')
    
      59b2sums=('SKIP'
    
      60        'ffb8f7bab4fd84aacf13e7b6d2835daf449b6650b4b3fa723456792ba7fb6cae352928fea11cb030510d558ce30036ff5a1513444f067b94c7fff0158b4f2265')
    
      61
    
      62pkgver() {
    
      63  # Grab version from package.json and append revisions since and last git commit_hash.
    
      64  cd "${_pkgname}"
    
      65  version=$(jq -r '.version' package.json 2>/dev/null | tr '-' '.')
    
      66  commit_hash=$(git rev-parse --short HEAD 2>/dev/null)
    
      67  latest_tag=$(git tag --sort=-v:refname | head -n1 2>/dev/null)
    
      68  commits_ahead=$( [[ -n "$latest_tag" ]] && git rev-list --count HEAD --not "$latest_tag" || echo 0 )
    
      69  [[ -n "$version" ]] && [[ -n "$commit_hash" ]] && echo "${version}.r${commits_ahead}.g${commit_hash}" || echo "unknown"
    
      70}
    
      71
    
      72prepare() {
    
      73  cd "${_pkgname}"
    
      74
    
      75  # git-lfs hook needs to be installed for one of the dependencies
    
      76  export GIT_CONFIG_GLOBAL="$HOME/.gitconfig"
    
      77  git lfs install
    
      78
    
      79  # Allow higher Node versions
    
      80  sed 's#"node": "#&>=#' -i package.json
    
      81
    
      82  # Install dependencies for sticker-creator
    
      83  pnpm install --dir sticker-creator
    
      84
    
      85  # Install dependencies for signal-desktop
    
      86  pnpm install
    
      87}
    
      88
    
      89build() {
    
      90  cd "${_pkgname}"
    
      91
    
      92  # Build the sticker creator
    
      93  pnpm --prefix ./sticker-creator/ run build
    
      94
    
      95  # Build signal-desktop
    
      96  pnpm run build
    
      97}
    
      98
    
      99package() {
    
      100  cd "${_pkgname}"
    
      101
    
      102  install -d "${pkgdir}/usr/"{lib,bin}
    
      103  cp -a release/linux-unpacked "${pkgdir}/usr/lib/${_pkgname,,}"
    
      104  ln -s "/usr/lib/${_pkgname,,}/${_pkgname,,}" "${pkgdir}/usr/bin/"
    
      105  chmod u+s "${pkgdir}/usr/lib/${_pkgname,,}/chrome-sandbox"
    
      106
    
      107  install -Dm 644 "../${_pkgname,,}.desktop" -t "${pkgdir}/usr/share/applications"
    
      108  for i in 16 24 32 48 64 128 256 512 1024; do
    
      109    install -Dm 644 "build/icons/png/${i}x${i}.png" \
    
      110      "${pkgdir}/usr/share/icons/hicolor/${i}x${i}/apps/${_pkgname,,}.png"
    
      111  done
    
      112}
    
      113

Scan history

Scanned at (UTC)	Severity	Rules
2026-08-03 00:08:14	LOW	2
2026-08-02 00:16:08	LOW	2
2026-08-01 00:11:18	LOW	2
2026-07-31 00:14:10	LOW	2
2026-07-30 00:17:23	LOW	2
2026-07-29 00:25:53	LOW	2
2026-07-28 00:07:28	LOW	2
2026-07-27 00:24:32	LOW	2
2026-07-26 00:07:32	LOW	2
2026-07-25 00:13:44	LOW	2
2026-07-24 00:02:28	LOW	2
2026-07-23 00:14:47	LOW	2
2026-07-22 00:29:32	LOW	2
2026-07-21 00:24:15	LOW	2
2026-07-20 00:19:49	LOW	2
2026-07-19 00:17:08	LOW	2
2026-07-18 00:14:48	LOW	2
2026-07-17 00:06:16	LOW	2
2026-07-16 00:05:41	LOW	2
2026-07-15 00:09:25	LOW	2