superlauncher-mc

maintainer ludvig2457 · 1 votes · scanned 2026-08-03 00:08:14.047287

MEDIUM

Why flagged The PKGBUILD uses `sha256sums=('SKIP')` for the source tarball, meaning the downloaded source is never integrity-checked. More importantly, it runs `pip install` during the `package()` phase to pull in multiple PyPI packages (pyqt6, minecraft-launcher-lib, requests, psutil, pypresence, packaging, tqdm, random-username) without any version pinning or hash verification. These packages are fetched at build time from PyPI with no integrity guarantees, creating a real supply-chain risk: any of these packages could be compromised or typosquatted (e.g. 'random-username' is a relatively obscure package). Additionally, creating a venv inside `pkgdir` and running pip into it during packaging is non-standard and means the installed package contains a venv with unverified, unpinned dependencies that will not receive system updates. The combination of SKIP checksums, unpinned pip installs of multiple packages (including less-common ones), and execution of downloaded code during the build phase constitutes a genuine medium-severity supply-chain concern.

Triggered rules

MEDIUM pip install of an external package pip_install_external

`pip install <package>` fetches an unpinned package from PyPI at build time, outside source=() and makepkg's checksums.

PKGBUILD:40 "$pkgdir/usr/share/superlauncher-mc/venv/bin/python" -m pip install --upgrade pip

MEDIUM AI review llm_review

An AI model (anthropic/claude-4.6-sonnet-20260217) reviewed this and agrees it is MEDIUM (confidence 72%): The PKGBUILD uses `sha256sums=('SKIP')` for the source tarball, meaning the downloaded source is never integrity-checked. More importantly, it runs `pip install` during the `package()` phase to pull in multiple PyPI packages (pyqt6, minecraft-launcher-lib, requests, psutil, pypresence, packaging, tqdm, random-username) without any version pinning or hash verification. These packages are fetched at build time from PyPI with no integrity guarantees, creating a real supply-chain risk: any of these packages could be compromised or typosquatted (e.g. 'random-username' is a relatively obscure package). Additionally, creating a venv inside `pkgdir` and running pip into it during packaging is non-standard and means the installed package contains a venv with unverified, unpinned dependencies that will not receive system updates. The combination of SKIP checksums, unpinned pip installs of multiple packages (including less-common ones), and execution of downloaded code during the build phase constitutes a genuine medium-severity supply-chain concern.

PKGBUILD

1 offending line(s) highlighted

      1# Maintainer: Ludvig <artemludvig79@gmail.com>
    
      2
    
      3pkgname=superlauncher-mc
    
      4pkgver=1.4.0.9
    
      5pkgrel=1
    
      6pkgdesc="SuperLauncherMC — Advanced Minecraft launcher with mod and server support (new design release)"
    
      7arch=('x86_64')
    
      8url="https://github.com/ludvig2457/SuperLauncherMC"
    
      9license=('GPL3')
    
      10depends=(
    
      11    'python'
    
      12    'python-pyqt6'
    
      13    'java-runtime'
    
      14)
    
      15makedepends=(
    
      16    'python-pip'
    
      17    'python-virtualenv'
    
      18)
    
      19source=(
    
      20    "$pkgname-$pkgver.tar.gz::https://github.com/ludvig2457/SuperLauncherMC/archive/v$pkgver.tar.gz"
    
      21)
    
      22sha256sums=('SKIP')
    
      23
    
      24package() {
    
      25    cd "$srcdir/SuperLauncherMC-$pkgver"
    
      26
    
      27    # Установка директории лаунчера
    
      28    install -d "$pkgdir/usr/share/superlauncher-mc"
    
      29    cp -r SuperLauncher.py assets "$pkgdir/usr/share/superlauncher-mc/"
    
      30
    
      31    # Добавляем шебанг для python3, если его нет
    
      32    if ! head -n 1 SuperLauncher.py | grep -q "^#\!"; then
    
      33        sed -i '1i#!/usr/bin/env python3' SuperLauncher.py
    
      34    fi
    
      35
    
      36    # Создаём virtual environment
    
      37    python -m venv "$pkgdir/usr/share/superlauncher-mc/venv"
    
      38
    
      39    # Устанавливаем библиотеки в venv
    
      40    "$pkgdir/usr/share/superlauncher-mc/venv/bin/python" -m pip install --upgrade pip
    
      41    "$pkgdir/usr/share/superlauncher-mc/venv/bin/python" -m pip install \
    
      42        pyqt6 minecraft-launcher-lib requests psutil pypresence packaging tqdm random-username
    
      43
    
      44    # Создаём wrapper для запуска через venv напрямую
    
      45    install -d "$pkgdir/usr/bin"
    
      46    cat <<EOF > "$pkgdir/usr/bin/superlauncher-mc"
    
      47#!/usr/bin/env bash
    
      48DIR="/usr/share/superlauncher-mc"
    
      49exec "\$DIR/venv/bin/python" "\$DIR/SuperLauncher.py" "\$@"
    
      50EOF
    
      51    chmod +x "$pkgdir/usr/bin/superlauncher-mc"
    
      52
    
      53    # Desktop-файл
    
      54    install -d "$pkgdir/usr/share/applications"
    
      55    cat <<EOF > "$pkgdir/usr/share/applications/superlauncher-mc.desktop"
    
      56[Desktop Entry]
    
      57Name=SuperLauncherMC
    
      58Comment=Advanced Minecraft Launcher with mod and server support
    
      59Exec=/usr/bin/superlauncher-mc
    
      60Icon=superlauncher
    
      61Type=Application
    
      62Categories=Game;
    
      63Terminal=false
    
      64EOF
    
      65
    
      66    # Иконка
    
      67    install -Dm644 assets/icon.png "$pkgdir/usr/share/pixmaps/superlauncher.png"
    
      68}
    
      69

Scan history

Scanned at (UTC)	Severity	Rules
2026-08-03 00:08:14	MEDIUM	2
2026-08-02 00:16:08	MEDIUM	2
2026-08-01 00:11:18	MEDIUM	2
2026-07-31 00:14:10	MEDIUM	2
2026-07-30 00:17:23	MEDIUM	2
2026-07-29 00:25:53	MEDIUM	2
2026-07-28 00:07:28	MEDIUM	2
2026-07-27 00:24:32	MEDIUM	2
2026-07-26 00:07:32	MEDIUM	2
2026-07-25 00:13:44	MEDIUM	2
2026-07-24 00:02:28	MEDIUM	2
2026-07-23 00:14:47	MEDIUM	2
2026-07-22 00:29:32	MEDIUM	2
2026-07-21 00:24:15	MEDIUM	2
2026-07-20 00:19:49	MEDIUM	2
2026-07-19 00:17:08	MEDIUM	2
2026-07-18 00:14:48	MEDIUM	2
2026-07-17 00:06:16	MEDIUM	2
2026-07-16 00:05:41	MEDIUM	2
2026-07-15 00:09:25	MEDIUM	2