yet-another-electron-term

maintainer zxp19821005 · 0 votes · scanned 2026-08-03 00:08:14.047287

LOW

Why flagged The npx commands in the build() function run project-local tools (patch-package, ng, electron-builder) as part of a standard Angular/Electron build process; these are declared devDependencies installed from the project's own package.json, not arbitrary remote code execution.

Triggered rules

LOW AI review downgraded a static finding llm_review

The static rules flagged this MEDIUM, but an AI model (qwen/qwen3-235b-a22b-07-25) reviewed the full PKGBUILD and judged it LOW (confidence 95%): The npx commands in the build() function run project-local tools (patch-package, ng, electron-builder) as part of a standard Angular/Electron build process; these are declared devDependencies installed from the project's own package.json, not arbitrary remote code execution.

1 higher static finding superseded - not the current verdict (shown for transparency)

MEDIUM npx/bunx/deno executes a remote package remote_code_tool

`npx`/`bunx`/`pnpm dlx`/`deno run <url>` downloads AND runs a remote package at build time — the moral equivalent of piping a download into a shell. Severity downgraded: Node.js consumer context.

PKGBUILD:95 echo N | NODE_ENV=production npx patch-package
PKGBUILD:96 NODE_ENV=production npx ng build --base-href ./

PKGBUILD

2 offending line(s) highlighted

      1# Maintainer: zxp19821005 <zxp19821005 at 163 dot com>
    
      2pkgname=yet-another-electron-term
    
      3_pkgname=YAET
    
      4pkgver=7.1.1
    
      5_electronversion=39
    
      6_nodeversion=22
    
      7pkgrel=1
    
      8pkgdesc="A remote connection tool based on angular + electron supporting SSH Telnet WinRM, RDP VNC, SCP/SFTP FTP SAMBA.(Use system-wide electron)"
    
      9arch=('any')
    
      10url="https://github.com/invince/YAET"
    
      11license=('Apache-2.0')
    
      12depends=(
    
      13    "electron${_electronversion}"
    
      14    'python'
    
      15    'libsecret'
    
      16)
    
      17makedepends=(
    
      18    'npm'
    
      19    'nvm'
    
      20    'git'
    
      21    'curl'
    
      22    'gendesk'
    
      23    'jq'
    
      24)
    
      25source=(
    
      26    "${pkgname}-${pkgver}::git+${url}#tag=v${pkgver}"
    
      27    "${pkgname}.sh"
    
      28)
    
      29sha256sums=('9ba16757c4d8ec2ca462c1aba86e4159e5c342fd9ae983ed0fd495136a09e777'
    
      30            'a774c2f54fbbeeaac3cefc0f7250796d30c86d27f0fd40b7eaf9c0fdb021623d')
    
      31_ensure_local_nvm() {
    
      32    local NVM_DIR="${srcdir}/.nvm"
    
      33    source /usr/share/nvm/init-nvm.sh || [[ $? != 1 ]]
    
      34    nvm install "${_nodeversion}"
    
      35    nvm use "${_nodeversion}"
    
      36}
    
      37_get_app_dir() {
    
      38    find "${srcdir}" -type f -name "resources.pak" -exec dirname {} + | head -n 1
    
      39}
    
      40_set_build_env() {
    
      41    export ELECTRON_DIST="/usr/lib/electron${_electronversion}"
    
      42    export ELECTRON_SKIP_BINARY_DOWNLOAD=1
    
      43    export SYSTEM_ELECTRON_VERSION="$(electron${_electronversion} -v | sed 's/v//g')"
    
      44    export HOME="${srcdir}/.electron-gyp"
    
      45    export NPM_CONFIG_CACHE="${srcdir}/.npm_cache"
    
      46    export NPM_CONFIG_MAXSOCKETS=32
    
      47    if [[ "$(curl -s ipinfo.io/country)" == *"CN"* ]]; then
    
      48        {
    
      49            export NPM_CONFIG_REGISTRY="https://registry.npmmirror.com"
    
      50            export NPM_CONFIG_ELECTRON_MIRROR="https://registry.npmmirror.com/-/binary/electron/"
    
      51            export NPM_CONFIG_ELECTRON_BUILDER_BINARIES_MIRROR="https://registry.npmmirror.com/-/binary/electron-builder-binaries/"
    
      52            export NODEJS_ORG_MIRROR="https://npmmirror.com/mirrors/node"
    
      53            export ELECTRON_MIRROR="https://npmmirror.com/mirrors/electron/"
    
      54            export ELECTRON_BUILDER_BINARIES_MIRROR="https://npmmirror.com/mirrors/electron-builder-binaries/"
    
      55        }
    
      56        find ./ -type f -name "package-lock.json" -exec sed -i "s/registry.npmjs.org/registry.npmmirror.com/g" {} +
    
      57    fi
    
      58}
    
      59_get_electron_version() {
    
      60    _elec_ver=$(find "${srcdir}" -maxdepth 5 -name "package.json" ! -path "*/node_modules/*" \
    
      61        -exec grep -l '"electron"' {} + | xargs -I{} jq -r '(.devDependencies.electron // .dependencies.electron) // empty' {} 2>/dev/null | head -1)
    
      62    [[ -z "${_elec_ver}" ]] && return 1
    
      63    echo -e "The electron version is: \033[1;31m${_elec_ver%%.*}\033[0m"
    
      64}
    
      65prepare() {
    
      66    cd "${srcdir}/${pkgname}-${pkgver}"
    
      67    _get_electron_version
    
      68    sed -i -e "
    
      69        s/@electronversion@/${_electronversion}/g
    
      70        s/@appname@/${pkgname}/g
    
      71        s/@runname@/app.asar/g
    
      72        s/@cfgdirname@/${_pkgname}/g
    
      73    " "${srcdir}/${pkgname}.sh"
    
      74    gendesk -q -f -n \
    
      75        --pkgname="${pkgname}" \
    
      76        --pkgdesc="${pkgdesc}" \
    
      77        --categories="Utility;System" \
    
      78        --name="${_pkgname}" \
    
      79        --exec="${pkgname} %U"
    
      80    _set_build_env
    
      81    _ensure_local_nvm
    
      82    sed -i "s/\"electron\": \"[^\"]*\"/\"electron\": \"${SYSTEM_ELECTRON_VERSION}\"/g" package.json
    
      83    sed -i -e "
    
      84        /const path = require(\"path\");/a \\
    
      85        const os = require('os');\nconst configHome = process.env.XDG_CONFIG_HOME || path.join(os.homedir(), '.config');
    
      86        s|const logPath = \`\${__dirname}/logs/main.log\`;|const logPath = path.join(configHome, '${pkgname}', 'logs', 'main.log');|
    
      87        " src-electron/electronMain.js
    
      88    NODE_ENV=development    npm install
    
      89}
    
      90build() {
    
      91    cd "${srcdir}/${pkgname}-${pkgver}"
    
      92    _set_build_env
    
      93    _ensure_local_nvm
    
      94    NODE_ENV=production     npm run clean
    
      95    echo N | NODE_ENV=production     npx patch-package
    
      96    NODE_ENV=production     npx ng build --base-href ./
    
      97    NODE_ENV=production     npm exec -c "electron-builder --linux dir -c.electronDist=${ELECTRON_DIST}"
    
      98}
    
      99package() {
    
      100    install -Dm755 "${srcdir}/${pkgname}.sh" "${pkgdir}/usr/bin/${pkgname}"
    
      101    install -Dm755 -d "${pkgdir}/usr/lib/${pkgname}"
    
      102	local _app_dir=$(_get_app_dir)
    
      103	cp -a "${_app_dir}/resources/". "${pkgdir}/usr/lib/${pkgname}/"
    
      104    install -Dm644 "${srcdir}/${pkgname}-${pkgver}/src-electron/assets/icons/app-icon.png" "${pkgdir}/usr/share/pixmaps/${pkgname}.png"
    
      105    install -Dm644 "${srcdir}/${pkgname}-${pkgver}/${pkgname}.desktop" -t "${pkgdir}/usr/share/applications"
    
      106    install -Dm644 "${srcdir}/${pkgname}-${pkgver}/LICENSE.txt" -t "${pkgdir}/usr/share/licenses/${pkgname}"
    
      107}
    
      108

Scan history

Scanned at (UTC)	Severity	Rules
2026-08-03 00:08:14	LOW	2
2026-08-02 00:16:08	LOW	2
2026-08-01 00:11:18	LOW	2
2026-07-31 00:14:10	LOW	2
2026-07-30 00:17:23	LOW	2
2026-07-29 00:25:53	LOW	2
2026-07-28 00:07:28	LOW	2
2026-07-27 00:24:32	LOW	2
2026-07-26 00:07:32	LOW	2
2026-07-25 00:13:44	LOW	2
2026-07-24 00:02:28	LOW	2
2026-07-23 00:14:47	LOW	2
2026-07-22 00:29:32	LOW	2
2026-07-21 00:24:15	LOW	2
2026-07-20 00:19:49	LOW	2
2026-07-19 00:17:08	LOW	2
2026-07-18 00:14:48	LOW	2
2026-07-17 00:06:16	LOW	2
2026-07-16 00:05:41	LOW	2
2026-07-15 00:09:25	LOW	2